From: Dave Chinner <david@fromorbit.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Eryu Guan <eguan@redhat.com>, fstests@vger.kernel.org, hughd@google.com
Subject: Re: [PATCH 04/12] generic: add _require_odirect to three more tests
Date: Thu, 11 Feb 2016 09:51:23 +1100 [thread overview]
Message-ID: <20160210225123.GZ19486@dastard> (raw)
In-Reply-To: <20160210161135.GG26922@thunk.org>
On Wed, Feb 10, 2016 at 11:11:35AM -0500, Theodore Ts'o wrote:
> On Wed, Feb 10, 2016 at 05:15:13PM +0800, Eryu Guan wrote:
> >
> > generic/125 only runs "./src/ftrunc" and I don't see where O_DIRECT is
> > being used, did I miss anything?
>
> generic/125 also calls "src/trunc", which does use O_DIRECT.
>
> (Hmm, and it assumes '.' is in the test's path, which I don't think is
> a safe thing to do.)
Perhaps one should question whether generic/125 is actually testing
anything useful in the first place.
i.e. it's writing 16k, then truncating it back to 1000 bytes, then
reading it with direct IO for 60s to see if it returns the correct
data for that entire time.
What, exactly, is going to cause that test to fail?
Keep in mind this was ported from a CXFS test, where the metadata
server did the truncation operation (including the data zeroing),
but the reads are being done from the client. i.e. it was designed
to test whether a remote machine is doing a truncate correctly on a
access shared disk.
IMO, I think we just remove the test, src/trunc.c and src/ftrunc.c
because it's 60s of testing that doesn't actually provide any value
to us.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2016-02-10 22:51 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 1:49 [PATCH 00/12] xfstests: fix up various tmpfs failures Theodore Ts'o
2016-02-10 1:49 ` [PATCH 01/12] check: avoid error messages of tests/$FS does not exist Theodore Ts'o
2016-02-10 5:45 ` Dave Chinner
2016-02-10 15:34 ` Theodore Ts'o
2016-02-10 16:28 ` Christoph Hellwig
2016-02-10 23:17 ` Theodore Ts'o
2016-02-10 22:19 ` Dave Chinner
2016-02-10 23:32 ` Theodore Ts'o
2016-02-10 1:49 ` [PATCH 02/12] common: _scratch_mkfs_sized() for tmpfs Theodore Ts'o
2016-02-10 6:00 ` Dave Chinner
2016-02-10 15:58 ` Theodore Ts'o
2016-02-10 22:37 ` Dave Chinner
2016-02-10 1:49 ` [PATCH 03/12] generic: use mount point instead of device name Theodore Ts'o
2016-02-10 1:49 ` [PATCH 04/12] generic: add _require_odirect to three more tests Theodore Ts'o
2016-02-10 9:15 ` Eryu Guan
2016-02-10 16:11 ` Theodore Ts'o
2016-02-10 22:51 ` Dave Chinner [this message]
2016-02-10 23:21 ` Theodore Ts'o
2016-02-10 1:49 ` [PATCH 05/12] xfstests: do not unmount tmpfs during remount Theodore Ts'o
2016-02-10 6:07 ` Dave Chinner
2016-02-10 16:07 ` Theodore Ts'o
2016-02-10 18:04 ` Theodore Ts'o
2016-02-10 23:07 ` Dave Chinner
2016-02-10 23:28 ` Theodore Ts'o
2016-02-11 3:07 ` Dave Chinner
2016-02-11 15:25 ` Theodore Ts'o
2016-02-11 17:36 ` Darrick J. Wong
2016-02-10 1:49 ` [PATCH 06/12] generic: do not unmount before calling _check_scratch_fs() Theodore Ts'o
2016-02-10 1:49 ` [PATCH 07/12] generic: require fiemap for generic/009 Theodore Ts'o
2016-02-10 1:49 ` [PATCH 08/12] xfstests: fix generic/312 on tmpfs, ignore /proc/partitions Theodore Ts'o
2016-02-10 5:54 ` Dave Chinner
2016-02-10 23:39 ` Theodore Ts'o
2016-02-11 2:53 ` Dave Chinner
2016-02-10 1:49 ` [PATCH 09/12] xfstests: generic/079 requires chattr, not xattrs Theodore Ts'o
2016-02-10 9:09 ` Eryu Guan
2016-02-10 16:09 ` Theodore Ts'o
2016-02-10 1:49 ` [PATCH 10/12] generic: disable generic/027 for tmpfs Theodore Ts'o
2016-02-10 5:58 ` Dave Chinner
2016-02-10 15:48 ` Theodore Ts'o
2016-02-10 23:13 ` Dave Chinner
2016-02-10 1:50 ` [PATCH 11/12] xfstests: add executable permission to tests Theodore Ts'o
2016-02-10 9:07 ` Eryu Guan
2016-02-10 1:50 ` [PATCH 12/12] xfstests: increase tmpfs memory size Theodore Ts'o
2016-02-10 2:10 ` [PATCH 00/12] xfstests: fix up various tmpfs failures Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160210225123.GZ19486@dastard \
--to=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=hughd@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox