Re: [PATCH] xfs: change return value check to golden image check

Zirong Lang
2016-02-19T15:43:25Z

----- 原始邮件 -----
> 发件人: "Zirong Lang" <zlang@redhat.com>
> 收件人: "Dave Chinner" <david@fromorbit.com>
> 抄送: fstests@vger.kernel.org, eguan@redhat.com
> 发送时间: 星期五, 2016年 2 月 19日 下午 11:35:23
> 主题: Re: [PATCH] xfs: change return value check to golden image check
>
>
>
> ----- 原始邮件 -----
> > 发件人: "Dave Chinner" <david@fromorbit.com>
> > 收件人: "Zorro Lang" <zlang@redhat.com>
> > 抄送: fstests@vger.kernel.org, eguan@redhat.com
> > 发送时间: 星期五, 2016年 2 月 19日 上午 9:33:16
> > 主题: Re: [PATCH] xfs: change return value check to golden image check
> >
> > On Fri, Feb 12, 2016 at 12:37:36AM +0800, Zorro Lang wrote:
> > > xfs/133 and xfs/138 use too much code to do "return value" check,
> > > it's not necessary. For the code can be more readable and clear,
> > > I change "return value" check to golden image check.
> > >
> > > Signed-off-by: Zorro Lang <zlang@redhat.com>
> > > ---
> > > tests/xfs/133 | 20 +++++++-------------
> > > tests/xfs/133.out | 7 +++++++
> > > tests/xfs/138 | 26 ++++++++++++--------------
> > > tests/xfs/138.out | 12 ++++++++++++
> > > 4 files changed, 38 insertions(+), 27 deletions(-)
> >
> > This cause a xfs/133 failure like this on my systems:
> >
> > --- tests/xfs/133.out 2016-02-19 10:40:57.043131919 +1100
> > +++ /home/dave/src/xfstests-dev/results//xfs/xfs/133.out.bad 2016-02-19
> > 12:24:53.173589432 +1100
> > @@ -4,5 +4,6 @@
> > Filesystem Blocks Quota Limit Warn/Time Mounted on
> > SCRATCH_DEV 0 102400 204800 00 [--------] SCRATCH_MNT
> > === report command output ===
> > +(null) 0 0 0 00 [--------]
> > 123456-project 0 102400 204800 00 [--------]
>
> Wow, I reproduce this problem after I updated my xfsprogs-dev from:
>
> 12dd365 xfs_quota: modify commands which can't handle multiple types

Sorry, 12dd365 is my private commit, which haven't been merged. It should from

1b9fecf libxfs: reset dirty buffer priority on lookup

>
> to:
>
> 1abecda xfsprogs: Release v4.5.0-rc1
>
> That's your newest Release recently. I need more check for this new failure.
>
> Thanks,
> Zorro
>
> >
> >
> > Can you see if you can reproduce it?
> >
> > Cheers,
> >
> > Dave.
> > --
> > Dave Chinner
> > david@fromorbit.com
> >
>