Re: [PATCH] xfs: change return value check to golden image check

Dave Chinner
2016-02-19T01:33:45Z

On Fri, Feb 12, 2016 at 12:37:36AM +0800, Zorro Lang wrote:
> xfs/133 and xfs/138 use too much code to do "return value" check,
> it's not necessary. For the code can be more readable and clear,
> I change "return value" check to golden image check.
>
> Signed-off-by: Zorro Lang <zlang@redhat.com>
> ---
> tests/xfs/133 | 20 +++++++-------------
> tests/xfs/133.out | 7 +++++++
> tests/xfs/138 | 26 ++++++++++++--------------
> tests/xfs/138.out | 12 ++++++++++++
> 4 files changed, 38 insertions(+), 27 deletions(-)

This cause a xfs/133 failure like this on my systems:

--- tests/xfs/133.out 2016-02-19 10:40:57.043131919 +1100
+++ /home/dave/src/xfstests-dev/results//xfs/xfs/133.out.bad 2016-02-19 12:24:53.173589432 +1100
@@ -4,5 +4,6 @@
Filesystem Blocks Quota Limit Warn/Time Mounted on
SCRATCH_DEV 0 102400 204800 00 [--------] SCRATCH_MNT
=== report command output ===
+(null) 0 0 0 00 [--------]
123456-project 0 102400 204800 00 [--------]

Can you see if you can reproduce it?

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com