From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Theodore Ts'o <tytso@mit.edu>,
fstests@vger.kernel.org, hughd@google.com
Subject: Re: [PATCH 05/16] generic: remove the generic/125 test
Date: Sun, 21 Feb 2016 23:36:18 -0800 [thread overview]
Message-ID: <20160222073618.GA28903@infradead.org> (raw)
In-Reply-To: <20160221215230.GD14668@dastard>
On Mon, Feb 22, 2016 at 08:52:30AM +1100, Dave Chinner wrote:
> On Wed, Feb 17, 2016 at 02:03:33AM -0800, Christoph Hellwig wrote:
> > The pNFS block layout driver works the same way as CXFS here. I
> > don't think I ever triggered this test during the development, though.
> >
> > I'm indifferent on whether we should keep this test or not, but it
> > defintively makes sense to remove it from the auto group.
>
> Ok, if there's some value to using it for pNFS testing, then lets
> leave it in place, remove the auto group but also add a "pnfs" group
> tag to it to document what it's useful for.
I think it might only be border line useful. If you two feel better if
it's gone I'm fine with killing it.
next prev parent reply other threads:[~2016-02-22 7:36 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-13 17:40 [PATCH-v3 00/16] tmpfs and other misc fixups for xfstests Theodore Ts'o
2016-02-13 17:40 ` [PATCH 01/16] ext4/001: add output variant for nodelalloc mounts Theodore Ts'o
2016-02-17 9:58 ` Christoph Hellwig
2016-02-13 17:40 ` [PATCH 02/16] check: avoid spurious complaints that tests/$FSTYP/group does not exist Theodore Ts'o
2016-02-17 9:59 ` Christoph Hellwig
2016-02-13 17:40 ` [PATCH 03/16] common: _scratch_mkfs_sized() for tmpfs Theodore Ts'o
2016-02-17 9:59 ` Christoph Hellwig
2016-02-13 17:40 ` [PATCH 04/16] generic: use mount point instead of device name Theodore Ts'o
2016-02-17 10:00 ` Christoph Hellwig
2016-02-13 17:40 ` [PATCH 05/16] generic: remove the generic/125 test Theodore Ts'o
2016-02-17 10:03 ` Christoph Hellwig
2016-02-21 21:52 ` Dave Chinner
2016-02-22 7:36 ` Christoph Hellwig [this message]
2016-02-13 17:40 ` [PATCH 06/16] generic: add _require_odirect to generic/113 and generic/214 Theodore Ts'o
2016-02-17 10:03 ` Christoph Hellwig
2016-02-13 17:41 ` [PATCH 07/16] Rename _scratch_mount to _scratch_cycle_mount Theodore Ts'o
2016-02-13 17:41 ` [PATCH 08/16] Rename _test_mount to _test_cycle_mount Theodore Ts'o
2016-02-13 17:41 ` [PATCH 09/16] xfstests: do not unmount tmpfs during remount Theodore Ts'o
2016-02-16 6:43 ` [PATCH-v3a " Theodore Ts'o
2016-02-17 3:05 ` [PATCH-v3b " Theodore Ts'o
2016-02-13 17:41 ` [PATCH 10/16] generic: do not unmount before calling _check_scratch_fs() Theodore Ts'o
2016-02-13 17:41 ` [PATCH 11/16] generic: require fiemap for generic/009 Theodore Ts'o
2016-02-17 10:04 ` Christoph Hellwig
2016-02-13 17:41 ` [PATCH 12/16] xfstests: remove dependency on /proc/partitions for generic/312 Theodore Ts'o
2016-02-17 10:06 ` Christoph Hellwig
2016-02-17 10:36 ` Eryu Guan
2016-02-13 17:41 ` [PATCH 13/16] xfstests: generic/079 and generic/277 requires chattr, not xattrs Theodore Ts'o
2016-02-17 10:06 ` Christoph Hellwig
2016-02-13 17:41 ` [PATCH 14/16] xfstests: add executable permission to tests Theodore Ts'o
2016-02-17 10:07 ` Christoph Hellwig
2016-02-13 17:41 ` [PATCH 15/16] xfstests: increase tmpfs memory size Theodore Ts'o
2016-02-17 10:08 ` Christoph Hellwig
2016-02-13 17:41 ` [PATCH 16/16] xfstests: remove _need_to_be_root Theodore Ts'o
2016-02-17 10:09 ` Christoph Hellwig
2016-02-17 12:22 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160222073618.GA28903@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=hughd@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox