Re: [PATCH v2] fstests: add btrfs test for fsync after snapshot deletion

Eryu Guan
2016-03-25T14:04:11Z

On Thu, Mar 24, 2016 at 08:08:36PM +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> Test that if we delete a snapshot, delete its parent directory, create
> another directory with the same name as that parent and then fsync either
> the new directory or a file inside the new directory, the fsync succeeds,
> the fsync log is replayable and produces a correct result.
>
> This is motivated by a bug that is fixed by the following patch for
> btrfs (linux kernel):
>
> Btrfs: fix unreplayable log after snapshot deletion and parent
> re-creation
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Looks good to me, test failed on v4.5 kernel and passed with above patch
(and dependencies) applied .

Reviewed-by: Eryu Guan <eguan@redhat.com>