Re: [PATCH] fstests: add btrfs test for fsync after snapshot deletion

Holger Hoffstätte
2016-03-25T12:10:19Z

On 03/25/16 04:53, Eryu Guan wrote:
> Test fails on v4.5 kernel as expected, but I failed to compile btrfs
> after applying this patch, seems btrfs_must_commit_transaction was not
> defined anywhere (I did grep it through the kernel tree, nothing showed
> up), did I miss anything?
>
> fs/btrfs/tree-log.c: In function ‘check_parent_dirs_for_sync’:
> fs/btrfs/tree-log.c:4836:4: error: implicit declaration of function ‘btrfs_must_commit_transaction’ [-Werror=implicit-function-declaration]
> if (btrfs_must_commit_transaction(trans, inode))
> ^
> cc1: some warnings being treated as errors
> make[1]: *** [fs/btrfs/tree-log.o] Error 1
> make: *** [_module_fs/btrfs] Error 2

It was defined in a previous patch for 4.6:

https://git.kernel.org/cgit/linux/kernel/git/mason/linux-btrfs.git/commit/?h=for-linus-4.6&id=2be63d5ce929603d4e7cedabd9e992eb34a0ff95

-h