From: Dave Chinner <david@fromorbit.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 2/2] common: teach _require_odirect that ext4 encryption doesn't support DIO
Date: Mon, 4 Apr 2016 09:08:38 +1000 [thread overview]
Message-ID: <20160403230838.GA11238@dastard> (raw)
In-Reply-To: <1459616174-31557-2-git-send-email-tytso@mit.edu>
On Sat, Apr 02, 2016 at 12:56:14PM -0400, Theodore Ts'o wrote:
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> ---
> common/rc | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/common/rc b/common/rc
> index 2ccca3b..961601b 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -1916,6 +1916,10 @@ _require_xfs_db_command()
> # check that kernel and filesystem support direct I/O
> _require_odirect()
> {
> + if [ $FSTYP = "ext4" ] &&
> + echo "$MOUNT_OPTIONS" | grep -q "test_dummy_encryption" ; then
> + _notrun "ext4 encryption doesn't support O_DIRECT"
> + fi
> testfile=$TEST_DIR/$$.direct
> $XFS_IO_PROG -F -f -d -c "pwrite 0 20k" $testfile > /dev/null 2>&1
Why isn't the direct IO failing here with an error sufficient to
prevent the test from running?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2016-04-03 23:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-02 16:56 [PATCH 1/2] Mark tests which use direct I/O with _requires_odirect Theodore Ts'o
2016-04-02 16:56 ` [PATCH 2/2] common: teach _require_odirect that ext4 encryption doesn't support DIO Theodore Ts'o
2016-04-03 23:08 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160403230838.GA11238@dastard \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox