public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Brian Foster <bfoster@redhat.com>
Cc: Jan Kara <jack@suse.cz>, fstests@vger.kernel.org
Subject: Re: [PATCH 2/5] generic/343: Test races between mmap and normal writes
Date: Wed, 27 Apr 2016 18:16:30 +0200	[thread overview]
Message-ID: <20160427161630.GB2553@quack2.suse.cz> (raw)
In-Reply-To: <20160427150434.GB44975@bfoster.bfoster>

On Wed 27-04-16 11:04:35, Brian Foster wrote:
> On Mon, Apr 18, 2016 at 09:32:32PM +0200, Jan Kara wrote:
> > diff --git a/tests/generic/341 b/tests/generic/341
> > index 1fde346adc85..05bd86707592 100644
> > --- a/tests/generic/341
> > +++ b/tests/generic/341
> > @@ -51,10 +51,6 @@ _supported_os Linux
> >  _require_scratch
> >  _require_dm_target flakey
> >  _require_metadata_journaling $SCRATCH_DEV
> > -
> > -rm -f $seqres.full
> > -
> > -_scratch_mkfs >>$seqres.full 2>&1
> >  _init_flakey
> >  _mount_flakey
> >  
> 
> What's this hunk about? FWIW, the rest of the series looks fine to me.

Argh, that sneaked in likely when I was rebasing the series and resolving
conflicts. This hunk should be dropped. Thanks for catching this!

								Honza

-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

  reply	other threads:[~2016-04-27 16:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-18 19:32 [PATCH 1/5] More page fault stress tests and generic/038 fix Jan Kara
2016-04-18 19:32 ` [PATCH 1/5] generic/340: Remove second fallocate test Jan Kara
2016-04-18 19:32 ` [PATCH 2/5] generic/343: Test races between mmap and normal writes Jan Kara
2016-04-27 15:04   ` Brian Foster
2016-04-27 16:16     ` Jan Kara [this message]
2016-04-27 16:19       ` Jan Kara
2016-04-18 19:32 ` [PATCH 3/5] generic/344: Test races between mmap and normal write for prefaulted ranges Jan Kara
2016-04-18 19:32 ` [PATCH 4/5] generic/345: Test races between processes doing mmap writes Jan Kara
2016-04-18 19:32 ` [PATCH 5/5] generic/038: Avoid EBUSY errors on umount Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160427161630.GB2553@quack2.suse.cz \
    --to=jack@suse.cz \
    --cc=bfoster@redhat.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox