From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] fstests: fix various $seqres.full issues
Date: Mon, 9 May 2016 16:05:30 +1000 [thread overview]
Message-ID: <20160509060530.GT18496@dastard> (raw)
In-Reply-To: <1462358277-27766-1-git-send-email-eguan@redhat.com>
On Wed, May 04, 2016 at 06:37:57PM +0800, Eryu Guan wrote:
> There're many tests don't remove $seqres.full before writing to it, and
> accumulating logs there, then the logs are always growing over time.
> Let's fix them once.
>
> generic/16[1-8] generic/170 and generic/33[34] truncate $seqres.full in
> the middle of the test, which results in partial logs. Fix them as well.
>
> xfs/227 has duplicated lines to remove $seqres.full, remove the extra
> line.
.....
> diff --git a/tests/xfs/261 b/tests/xfs/261
> index 950c539..962f6fc 100755
> --- a/tests/xfs/261
> +++ b/tests/xfs/261
> @@ -51,6 +51,7 @@ _cleanup()
> . ./common/quota
>
> echo "Silence is golden."
> +rm -r $seqres.full
^^
I think you meant rm -f. Test fails when $seqres.full doesn't
exist...
I've fixed it up.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2016-05-09 6:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 10:37 [PATCH] fstests: fix various $seqres.full issues Eryu Guan
2016-05-05 0:26 ` Darrick J. Wong
2016-05-09 6:05 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160509060530.GT18496@dastard \
--to=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox