Re: [PATCH] fstests: btrfs: Test fiemap ioctl on completely deduped file

Dave Chinner
2016-05-12T01:19:55Z

On Thu, May 12, 2016 at 08:46:41AM +0800, Qu Wenruo wrote:
> >Filesystem type is: 58465342
> >File size of a is 262144 (64 blocks of 4096 bytes)
> > ext: logical_offset: physical_offset: length: expected: flags:
> > 0: 0.. 31: 24.. 55: 32: shared
> > 1: 32.. 63: 24.. 55: 32: 56: last,shared,eof
>
> Also the "shared" flag is different from btrfs, where btrfs is
> wrong, and the btrfs routine to check shared extent caused the soft
> lockup.
>
> I originally planned to check "shared" flag, but the soft lockup is
> more important, and 8000+ output seems not suitable as golden
> output.

If that's what the test produces for correct behaviour, then there
isn't any problem with having golden output that large. e.g.
tests/xfs/136.out has 7800 lines in its golden output file. There
are quite a few tests with large amounts of output:

$ find . -name *.out -exec ls -s {} \; |sort -nr |head -5
144 ./tests/xfs/136.out
124 ./tests/generic/324.out
120 ./tests/xfs/165.out
116 ./tests/xfs/107.out
92 ./tests/btrfs/034.out
$

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com