Re: [PATCH 6/7] xfs: test rmap behavior when multiple bmbt records map to a single rmapbt record

Darrick J. Wong
2016-05-26T16:13:28Z

On Thu, May 26, 2016 at 01:04:24AM -0700, Christoph Hellwig wrote:
> > --- a/src/t_immutable.c
> > +++ b/src/t_immutable.c
> > @@ -38,10 +38,10 @@
> > #include <libgen.h>
> > #include <sys/acl.h>
> > #include <attr/xattr.h>
> > +#include <linux/fs.h>
> > #include <xfs/xfs.h>
> > #include <xfs/handle.h>
> > #include <xfs/jdm.h>
> > -#include <linux/fs.h>
> > #include <linux/magic.h>
> >
> > #ifndef XFS_SUPER_MAGIC
>
> How does this belong into the patch?

It doesn't, this somehow jumped patches when I rebased. :/

> > diff --git a/tests/xfs/group b/tests/xfs/group
> > index f0ca410..0e34f9a 100644
> > --- a/tests/xfs/group
> > +++ b/tests/xfs/group
> > @@ -288,3 +288,4 @@
> > 853 auto quick clone
> > 854 auto quick clone
> > 855 auto clone
> > +856 auto clone rmap reflink
>
> This is the only test in the reflink group, how is this group different
> from the clone one?

I'm just gonna say 'thinko' and respin. :)

/me pours a larger cup of coffee...

(Thx for the review!)

--D