From: Dave Chinner <david@fromorbit.com>
To: Omer Zilberberg <omzg@plexistor.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH v2] generic/294: filter quotes from mknod
Date: Wed, 29 Jun 2016 16:15:29 +1000 [thread overview]
Message-ID: <20160629061529.GT27480@dastard> (raw)
In-Reply-To: <1467032008-16374-1-git-send-email-omzg@plexistor.com>
On Mon, Jun 27, 2016 at 03:53:28PM +0300, Omer Zilberberg wrote:
> Since coreutils v8.25, mknod errors omit quotes around filenames, and
> this breaks generic/294's golden image.
>
> Checked on Ubuntu 16.04.
>
> See coreutils: 08e8fd7 all: avoid quoting file names when possible
> https://github.com/coreutils/coreutils/commit/08e8fd7e38f2dae7c69c54eb22d508b6517e66e5
>
> Signed-off-by: Omer Zilberberg <omzg@plexistor.com>
>
> v2: added comment to _filter_mknod.
> ---
> common/filter | 7 +++++++
> tests/generic/294 | 2 +-
> tests/generic/294.out | 2 +-
> 3 files changed, 9 insertions(+), 2 deletions(-)
$ git grep -l mknod common/ tests/
common/dmflakey
common/populate
tests/btrfs/004
tests/generic/062
tests/generic/085
tests/generic/117
tests/generic/157
tests/generic/158
tests/generic/184
tests/generic/294
tests/generic/294.out
tests/generic/306
tests/overlay/003
tests/xfs/106
$
Do any of these other tests that call mknod need this filtering?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2016-06-29 6:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 12:53 [PATCH v2] generic/294: filter quotes from mknod Omer Zilberberg
2016-06-28 3:30 ` Eryu Guan
2016-06-29 6:15 ` Dave Chinner [this message]
2016-06-29 6:27 ` Omer Zilberberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160629061529.GT27480@dastard \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=omzg@plexistor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox