Re: [PATCH 16/20] reflink: test cross-mountpoint reflink and dedupe

Eryu Guan
2016-07-04T06:51:40Z

On Thu, Jun 16, 2016 at 06:47:42PM -0700, Darrick J. Wong wrote:
> Test sharing blocks via reflink and dedupe between two different
> mountpoints of the same filesystem. This shouldn't work, since
> we don't allow cross-mountpoint functions.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> common/reflink | 2 +
> tests/generic/927 | 88 +++++++++++++++++++++++++++++++++++++++++++++++++
> tests/generic/927.out | 9 +++++
> tests/generic/928 | 86 ++++++++++++++++++++++++++++++++++++++++++++++++
> tests/generic/928.out | 10 ++++++
> tests/generic/group | 2 +
> 6 files changed, 196 insertions(+), 1 deletion(-)
> create mode 100755 tests/generic/927
> create mode 100644 tests/generic/927.out
> create mode 100755 tests/generic/928
> create mode 100644 tests/generic/928.out
>
>
> diff --git a/common/reflink b/common/reflink
> index 4ec390d..1363971 100644
> --- a/common/reflink
> +++ b/common/reflink
> @@ -107,7 +107,7 @@ _require_scratch_dedupe()
> _scratch_mount
> "$XFS_IO_PROG" -f -c "pwrite -S 0x61 0 65536" "$SCRATCH_MNT/file1" > /dev/null
> "$XFS_IO_PROG" -f -c "pwrite -S 0x61 0 65536" "$SCRATCH_MNT/file2" > /dev/null
> - testio="$("$XFS_IO_PROG" -f -c "dedupe $TEST_DIR/file1 0 0 65536" "$TEST_DIR/file2" 2>&1)"
> + testio="$("$XFS_IO_PROG" -f -c "dedupe $SCRATCH_MNT/file1 0 0 65536" "$SCRATCH_MNT/file2" 2>&1)"
> echo $testio | grep -q "Operation not supported" && \
> _notrun "Dedupe not supported by test filesystem type: $FSTYP"
> echo $testio | grep -q "Inappropriate ioctl for device" && \

I think this hunk belongs to a seperate patch.

Thanks,
Eryu