Re: [PATCH 4/4] xfstests: filename handling - fix early wildcard expansion

Eryu Guan
2016-07-13T12:29:34Z

On Mon, Jul 11, 2016 at 11:26:09AM +0200, Jan Tulak wrote:
> Add quotation marks around the wildcarded name.

This makes no difference for me, the original code is working well. Did
I miss anything?

[root@dhcp-66-86-11 xfstests]# bname=999
[root@dhcp-66-86-11 xfstests]# find tests/xfs -name "$bname*"
tests/xfs/999-test-case
tests/xfs/999-test-case.out
[root@dhcp-66-86-11 xfstests]# find tests/xfs -name $bname*
tests/xfs/999-test-case
tests/xfs/999-test-case.out

Thanks,
Eryu

>
> Signed-off-by: Jan Tulak <jtulak@redhat.com>
> ---
> check | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/check b/check
> index 58d8869..5ff897b 100755
> --- a/check
> +++ b/check
> @@ -548,7 +548,7 @@ for section in $HOST_OPTIONS_SECTIONS; do
> # and the test has a name. A bit of hassle to find really
> # the test and not its sample output or helping files.
> bname=$(basename $seq)
> - full_seq=$(find $(dirname $seq) -name $bname* -executable |
> + full_seq=$(find $(dirname $seq) -name "$bname*" -executable |
> awk '(NR == 1 || length < length(shortest)) { shortest = $0 }\
> END { print shortest }')
> if [ -f $full_seq ] \
> --
> 2.5.5
>