From: Eryu Guan <eguan@redhat.com>
To: Jan Kara <jack@suse.cz>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] generic/235: Use CSV format for repquota output
Date: Tue, 19 Jul 2016 12:07:38 +0800 [thread overview]
Message-ID: <20160719040738.GK27776@eguan.usersys.redhat.com> (raw)
In-Reply-To: <1468843224-8940-1-git-send-email-jack@suse.cz>
On Mon, Jul 18, 2016 at 02:00:24PM +0200, Jan Kara wrote:
> Different quota format may print additional information in repquota(8)
> output after standard quota information is printed and this information
> is separated by two empty lines. For quota formats that don't support
> printing any additional information these lines are not present in the
> output which causes false failures of the test. Switch the test to use
> repquota(8) CSV output format which does not have these formatting
> issues and in general should be more stable.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
This breaks tests on distributions with older version of repquota (e.g.
RHEL6 and RHEL7) where there's no "-O" support, and test failed because
of "invalid option -- 'O'".
Thanks,
Eryu
next prev parent reply other threads:[~2016-07-19 4:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 12:00 [PATCH] generic/235: Use CSV format for repquota output Jan Kara
2016-07-19 4:07 ` Eryu Guan [this message]
2016-07-20 5:13 ` Jan Kara
2016-07-20 23:02 ` Dave Chinner
2016-07-21 7:27 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160719040738.GK27776@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=jack@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox