From: Christoph Hellwig <hch@lst.de>
To: Eryu Guan <eguan@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, fstests@vger.kernel.org
Subject: Re: [PATCH] generic/071: require falloc -k
Date: Tue, 19 Jul 2016 06:17:18 +0200 [thread overview]
Message-ID: <20160719041718.GA17223@lst.de> (raw)
In-Reply-To: <20160718084714.GD27776@eguan.usersys.redhat.com>
On Mon, Jul 18, 2016 at 04:47:14PM +0800, Eryu Guan wrote:
> This stops generic/071 from running no matter what filesystem it's
> testing, this is because _require_xfs_io_command only checks whether
> xfs_io knows the option (-k) by searching it in help message, not really
> running it, i.e.
Well, we can at least add the documentation as that would be useful
on it's own. I'll look into a patch.
> Perhaps we should update _require_xfs_io_command to actually run the
> command with the provided additional option?
I'll have to look at the archives, but I remember we had a reason for
this way of probing for feature support.
next prev parent reply other threads:[~2016-07-19 4:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 8:06 [PATCH] generic/071: require falloc -k Christoph Hellwig
2016-07-18 8:47 ` Eryu Guan
2016-07-19 4:17 ` Christoph Hellwig [this message]
2016-07-19 6:49 ` Eric Sandeen
2016-07-19 8:30 ` Christoph Hellwig
2016-07-20 4:52 ` Eryu Guan
2016-07-20 5:34 ` Eric Sandeen
2016-07-20 12:40 ` Eryu Guan
2016-07-20 4:38 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160719041718.GA17223@lst.de \
--to=hch@lst.de \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox