From: Eryu Guan <eguan@redhat.com>
To: Jan Kara <jack@suse.cz>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 2/2] generic/130: Improve xfs_io filter
Date: Thu, 21 Jul 2016 14:55:26 +0800 [thread overview]
Message-ID: <20160721065526.GB27776@eguan.usersys.redhat.com> (raw)
In-Reply-To: <1469081856-6424-2-git-send-email-jack@suse.cz>
On Thu, Jul 21, 2016 at 08:17:36AM +0200, Jan Kara wrote:
> On my test setup xfs_io reports 'nan' in bytes/s and ops/s fields when
> the operation takes zero time. Account for that in _filter_xfs_io.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> common/filter | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/filter b/common/filter
> index b229a97dfa0e..37f07c8ca1ac 100644
> --- a/common/filter
> +++ b/common/filter
> @@ -221,7 +221,7 @@ common_line_filter()
>
> _filter_xfs_io()
> {
> - sed -e "s/[0-9/.]* [GMKiBbytes]*, [0-9]* ops\; [0-9/:. sec]* ([inf0-9/.]* [EPGMKiBbytes]*\/sec and [inf0-9/.]* ops\/sec)/XXX Bytes, X ops\; XX:XX:XX.X (XXX YYY\/sec and XXX ops\/sec)/"
> + sed -e "s/[0-9/.]* [GMKiBbytes]*, [0-9]* ops\; [0-9/:. sec]* ([infnan0-9/.]* [EPGMKiBbytes]*\/sec and [infnan0-9/.]* ops\/sec)/XXX Bytes, X ops\; XX:XX:XX.X (XXX YYY\/sec and XXX ops\/sec)/"
Seems adding only 'a' to the char set is sufficient, 'n' is already in
the set, i.e.
- ...([inf0-9/.]* ...
+ ...([infa0-9/.]* ...
Thanks,
Eryu
next prev parent reply other threads:[~2016-07-21 6:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 6:17 [PATCH 1/2] generic/294: Filter backquotes from mknod error output Jan Kara
2016-07-21 6:17 ` [PATCH 2/2] generic/130: Improve xfs_io filter Jan Kara
2016-07-21 6:55 ` Eryu Guan [this message]
2016-07-21 7:35 ` Jan Kara
2016-07-21 8:14 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160721065526.GB27776@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=jack@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox