Re: [PATCH] generic/235: Use CSV format for repquota output

Jan Kara
2016-07-21T07:27:16Z

On Thu 21-07-16 09:02:31, Dave Chinner wrote:
> On Wed, Jul 20, 2016 at 07:13:24AM +0200, Jan Kara wrote:
> > On Tue 19-07-16 12:07:38, Eryu Guan wrote:
> > > On Mon, Jul 18, 2016 at 02:00:24PM +0200, Jan Kara wrote:
> > > > Different quota format may print additional information in repquota(8)
> > > > output after standard quota information is printed and this information
> > > > is separated by two empty lines. For quota formats that don't support
> > > > printing any additional information these lines are not present in the
> > > > output which causes false failures of the test. Switch the test to use
> > > > repquota(8) CSV output format which does not have these formatting
> > > > issues and in general should be more stable.
> > > >
> > > > Signed-off-by: Jan Kara <jack@suse.cz>
> > >
> > > This breaks tests on distributions with older version of repquota (e.g.
> > > RHEL6 and RHEL7) where there's no "-O" support, and test failed because
> > > of "invalid option -- 'O'".
> >
> > Hum, support for -O option is in repquota for three years. That isn't much
> > for enterprise distros, I agree. I can fix the problem with output
> > filtering. That will be less future-proof but it will work for old
> > repquota. I'm not sure what's more desirable. Dave?
>
> What are the extra lines? Why can't an output filter be added to
> strip the extra lines if they are emitted?

Those extra lines can be stripped. If that's preferable I'll send a patch
doing that. I just thought using CSV output format of repquota may be less
prone to formatting changes in the future.

Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR