From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <eguan@redhat.com>
Cc: Wang Xiaoguang <wangxg.fnst@cn.fujitsu.com>,
fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] generic/371: run write(2) and fallocate(2) in parallel
Date: Fri, 22 Jul 2016 09:05:19 +1000 [thread overview]
Message-ID: <20160721230519.GF12670@dastard> (raw)
In-Reply-To: <20160721104100.GD27776@eguan.usersys.redhat.com>
On Thu, Jul 21, 2016 at 06:41:00PM +0800, Eryu Guan wrote:
> On Thu, Jul 21, 2016 at 03:30:25PM +0800, Wang Xiaoguang wrote:
> > +
> > +run_time=$((180 * $TIME_FACTOR))
>
> 180s is too long time, I can reproduce it in around 10s on my test vm,
> just loop for 100 times for each operation (pwrite and falloc)
Or simply do:
run_time=$((20 * $TIME_FACTOR * $TIME_FACTOR))
So that the time factor scales up quickly when you want to run long
running tests.
> > --- a/tests/generic/group
> > +++ b/tests/generic/group
> > @@ -373,3 +373,4 @@
> > 368 auto quick richacl
> > 369 auto quick richacl
> > 370 auto quick richacl
> > +371 auto enospc prealloc stress
>
> So we can add 'quick' group and remove 'stress'.
I'd leave the test in stress if we can run it based on time as per
my above suggestion.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2016-07-21 23:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 7:30 [PATCH] generic/371: run write(2) and fallocate(2) in parallel Wang Xiaoguang
2016-07-21 10:41 ` Eryu Guan
2016-07-21 23:05 ` Dave Chinner [this message]
2016-07-25 7:10 ` Wang Xiaoguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160721230519.GF12670@dastard \
--to=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wangxg.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox