From: Christoph Hellwig <hch@infradead.org>
To: Eric Whitney <enwlinux@gmail.com>
Cc: fstests@vger.kernel.org, linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH] common/defrag: rework _require_defrag for ext4
Date: Thu, 11 Aug 2016 10:48:02 -0700 [thread overview]
Message-ID: <20160811174802.GC31540@infradead.org> (raw)
In-Reply-To: <20160804200246.GA2208@localhost.localdomain>
On Thu, Aug 04, 2016 at 04:02:46PM -0400, Eric Whitney wrote:
> The existing _require_defrag function rejects ext4 file systems
> mounted with the dax option or constructed without extents. However,
> there are also a number of other ext4 file system configuration cases
> that do not currently support online defrag, including encryption, data
> journaling, and bigalloc. In the future, online defrag functionality
> may be implemented for some of these, and new configuration cases
> could be added that don't support it.
>
> Rather than add a laundry list of mount and file system configuration
> options to the existing _require_defrag function that will need ongoing
> maintenance, use the available src/e4compact program to directly
> determine whether the kernel supports ext4's move extent ioctl on the
> test file system.
This look reasonable - but I wonder if we could just come up with an
even more generic version that uses your approach on all file systems,
so that the only per-fs logic left would be to apply the
DEFRAG_PROG variable.
prev parent reply other threads:[~2016-08-11 17:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 20:02 [PATCH] common/defrag: rework _require_defrag for ext4 Eric Whitney
2016-08-11 17:48 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160811174802.GC31540@infradead.org \
--to=hch@infradead.org \
--cc=enwlinux@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox