From: Eryu Guan <eguan@redhat.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>, fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH] xfs/263: test xfs_quota "state" command
Date: Tue, 16 Aug 2016 11:20:48 +0800 [thread overview]
Message-ID: <20160816032048.GK27776@eguan.usersys.redhat.com> (raw)
In-Reply-To: <6979e124-ee73-94e3-1c09-1dfb2d0b368a@sandeen.net>
On Mon, Aug 15, 2016 at 10:15:17PM -0500, Eric Sandeen wrote:
>
>
> On 8/15/16 9:48 PM, Eric Sandeen wrote:
> >
> >
> > On 8/15/16 12:36 AM, Eryu Guan wrote:
> >> On Fri, Aug 12, 2016 at 05:53:04PM -0500, Eric Sandeen wrote:
> >>> This exercises the xfs_quota "state" command for every
> >>> combination of user, group, and project quota enablement
> >>> on both crc (with project quota inode on disk) and non-crc
> >>> (where project quota overlaps group quota on disk) filesystems.
> >>>
> >>> It currently requires patches to the upstream kernel
> >>> ("quota: fill in Q_XGETQSTAT inode information for inactive quotas")
> >>> and to xfsprogs ("xfs_quota: wire up XFS_GETQSTATV") to pass.
> >>
> >> I've applied these patches to kernel (4.8-rc1 based) and xfsprogs
> >> (4.7-rc1 based), and the quota filter fix to xfstests, but I still saw
> >> failures on this, did I miss anything?
> >>
> >> [root@dhcp-66-86-11 xfstests]# diff -u tests/xfs/263.out /root/workspace/xfstests/results//xfs_4k_crc/xfs/263.out.bad
> >> --- tests/xfs/263.out 2016-08-15 10:56:23.973000000 +0800
> >> +++ /root/workspace/xfstests/results//xfs_4k_crc/xfs/263.out.bad 2016-08-15 13:29:48.934000000 +0800
> >> @@ -9,11 +9,11 @@
> >> Group quota state on SCRATCH_MNT (SCRATCH_DEV)
> >> Accounting: OFF
> >> Enforcement: OFF
> >> - Inode: N/A
> >> + Inode: #0 (0 blocks, 0 extents)
> >> Project quota state on SCRATCH_MNT (SCRATCH_DEV)
> >> Accounting: OFF
> >> Enforcement: OFF
> >> - Inode: N/A
> >> + Inode: #0 (0 blocks, 0 extents)
> >
> > strange, that's the kind of thing the kernel patch was intended to fix.
> >
> > I meant to retest from scratch on bleeding-edge upstream, but too many
> > things got in the way today. Will try again tomorrow...
>
> Can you recheck? I built everything from scratch on a freshly-installed
> box, and with the patches mentioned, it passes for me.
Sure, will do.
>
> oh, but try V2 of the xfsprogs patch ;) (I'll send that in a minute).
No problem :)
Thanks,
Eryu
next prev parent reply other threads:[~2016-08-16 3:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 22:53 [PATCH] xfs/263: test xfs_quota "state" command Eric Sandeen
2016-08-15 5:36 ` Eryu Guan
2016-08-16 2:48 ` Eric Sandeen
2016-08-16 3:15 ` Eric Sandeen
2016-08-16 3:20 ` Eryu Guan [this message]
2016-08-16 3:26 ` Eryu Guan
2016-08-16 3:23 ` [PATCH V2] " Eric Sandeen
2016-08-16 13:34 ` Bill O'Donnell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160816032048.GK27776@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox