From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Xiao Yang <yangx.jy@cn.fujitsu.com>
Cc: Zorro Lang <zlang@redhat.com>, fstests@vger.kernel.org
Subject: Re: [PATCH] xfs/098: fix xfs_repair on newer xfsprogs
Date: Fri, 26 Aug 2016 09:18:38 -0700 [thread overview]
Message-ID: <20160826161838.GF8265@birch.djwong.org> (raw)
In-Reply-To: <57BFB868.7030806@cn.fujitsu.com>
On Fri, Aug 26, 2016 at 11:32:56AM +0800, Xiao Yang wrote:
> 于 2016/08/25 23:40, Darrick J. Wong 写道:
> >On Thu, Aug 25, 2016 at 08:09:03PM +0800, Zorro Lang wrote:
> >>On Thu, Aug 25, 2016 at 05:22:31PM +0800, Xiao Yang wrote:
> >>>Make sure xfs_repair can't clear the log by default when it is corrupted.
> >>>xfs_repair always and only clear the log when the -L parameter is specified.
> >>>This has updated by:
> >>>Commit f2053bc ("xfs_repair: don't clear the log by default")
> >>>
> >>>Signed-off-by: Xiao Yang<yangx.jy@cn.fujitsu.com>
> >>>---
> >>> tests/xfs/098 | 4 +++-
> >>> 1 file changed, 3 insertions(+), 1 deletion(-)
> >>>
> >>>diff --git a/tests/xfs/098 b/tests/xfs/098
> >>>index d91d617..0fe8d93 100755
> >>>--- a/tests/xfs/098
> >>>+++ b/tests/xfs/098
> >>>@@ -93,7 +93,9 @@ echo "+ mount image"
> >>> _scratch_mount 2>/dev/null&& _fail "mount should not succeed"
> >>>
> >>> echo "+ repair fs"
> >>>-_scratch_xfs_repair>> $seqres.full 2>&1
> >>>+_scratch_xfs_repair>> $seqres.full 2>&1&& _fail "xfs_repair should not succeed without -L option"
> >>Hi,
> >>
> >>If you make it fail at here, this case can't run for old xfsprogs(without
> >>commit f2053bc).
> >>
> >>>+
> >>>+_scratch_xfs_repair -L>> $seqres.full 2>&1
> >>For compatibility, maybe you can use "-L" directly. Or use -L
> >>after _scratch_xfs_repair return error.
> >I suggest _repair_scratch_fs.
> >
> >--D
> >
> Hi Darrick
> I changed _repair_scratch_fs because xfs_repair return 1 when log is
> corrupted.
xfs_repair returns 2 when the log is corrupted, 1 when there's corruption left
to be fixed *or* some kind of operation error happened, and 0 if either it
found nothing wrong or all the corruptions were fixed. The manpage lies.
(Proceeding on to the rest of the messages in this thread...)
--D
> Thanks for your review.
>
> Regards,
> Xiao Yang
>
> >>Thanks,
> >>Zorro
> >>
> >>>
> >>> echo "+ mount image (2)"
> >>> _scratch_mount
> >>>--
> >>>1.8.3.1
> >>>
> >>>
> >>>
> >>>--
> >>>To unsubscribe from this list: send the line "unsubscribe fstests" in
> >>>the body of a message to majordomo@vger.kernel.org
> >>>More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> >
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-08-26 16:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 9:22 [PATCH] xfs/098: fix xfs_repair on newer xfsprogs Xiao Yang
2016-08-25 12:09 ` Zorro Lang
2016-08-25 15:40 ` Darrick J. Wong
2016-08-25 16:32 ` Zorro Lang
2016-08-26 3:32 ` Xiao Yang
2016-08-26 16:18 ` Darrick J. Wong [this message]
2016-08-26 3:36 ` [PATCH v2] " Xiao Yang
2016-08-26 4:42 ` Eryu Guan
2016-08-26 5:44 ` Xiao Yang
2016-08-26 4:48 ` Zorro Lang
2016-08-26 6:10 ` Xiao Yang
2016-08-26 9:05 ` Zorro Lang
[not found] ` <57D28101.6000902@cn.fujitsu.com>
2016-09-09 12:28 ` Zorro Lang
2016-09-12 1:07 ` Xiao Yang
2016-09-12 5:13 ` [PATCH v3] " Xiao Yang
2016-09-12 12:59 ` Eric Sandeen
2016-09-13 6:12 ` Xiao Yang
2016-09-13 7:08 ` Zorro Lang
2016-09-14 1:43 ` Xiao Yang
2016-09-14 2:52 ` [PATCH v4] " Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160826161838.GF8265@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=yangx.jy@cn.fujitsu.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox