From: Eryu Guan <eguan@redhat.com>
To: Wang Xiaoguang <wangxg.fnst@cn.fujitsu.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] generic/159: record error value correctly
Date: Tue, 30 Aug 2016 11:59:40 +0800 [thread overview]
Message-ID: <20160830035940.GJ27776@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20160830035114.13876-1-wangxg.fnst@cn.fujitsu.com>
On Tue, Aug 30, 2016 at 11:51:14AM +0800, Wang Xiaoguang wrote:
> This case failed in btrfs, it's because when trying to open an immutable
> file, vfs returns EPERM, not EACCESS, fix this.
>
> Signed-off-by: Wang Xiaoguang <wangxg.fnst@cn.fujitsu.com>
> ---
> tests/generic/159.out | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/generic/159.out b/tests/generic/159.out
> index 92fe33a..3e5e47f 100755
> --- a/tests/generic/159.out
> +++ b/tests/generic/159.out
> @@ -2,4 +2,4 @@ QA output created by 159
> Format and mount
> Create the original files
> Try reflink on immutable files
> -TEST_DIR/test-159/file2: Permission denied
> +TEST_DIR/test-159/file2: Operation not permitted
I think you need to do a filter in the test not change the golden image,
so older kernels won't fail because they still return EACCES on
immutable inodes.
Thanks,
Eryu
next prev parent reply other threads:[~2016-08-30 3:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 3:51 [PATCH] generic/159: record error value correctly Wang Xiaoguang
2016-08-30 3:59 ` Eryu Guan [this message]
2016-08-30 4:00 ` Wang Xiaoguang
2016-08-30 4:45 ` Darrick J. Wong
2016-08-30 5:31 ` Wang Xiaoguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160830035940.GJ27776@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wangxg.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox