From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>, fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH 3/3] move now-generic quota tests to generic
Date: Wed, 21 Sep 2016 09:40:48 +1000 [thread overview]
Message-ID: <20160920234048.GB10454@dastard> (raw)
In-Reply-To: <06d804f2-646e-a586-bed1-416ffde8e0e9@sandeen.net>
On Tue, Sep 20, 2016 at 05:24:59PM -0500, Eric Sandeen wrote:
> Now that these tests have been made generic, move them into
> the generic/ dir and update group files.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
I wonder if this would be better done simply as a tools/mvtest
script for the maintainer to run. e.g.
#!/bin/sh
tools/mvtest xfs/054 generic/380
tools/mvtest xfs/118 generic/381
tools/mvtest xfs/138 generic/382
tools/mvtest xfs/260 generic/383
#EOF
Rather than ending up with patch that won't apply because we've
already applied another patch that added a new test that conflicts?
Reviewing the change is also heaps easier :)
> ---
>
> diff --git a/tests/generic/group b/tests/generic/group
> index a602b01..f5ebbb1 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -381,3 +381,8 @@
> 376 auto quick metadata
> 377 attr auto quick metadata
> 378 auto quick metadata
> +380 quota auto quick
> +381 quota auto quick
> +382 auto quick quota
> +383 auto quick quota
> +
No trailing blank line....
> @@ -257,7 +254,6 @@
> 257 auto quick clone
> 258 auto quick clone
> 259 auto quick
> -260 auto quick quota
> 261 auto quick quota
> 262 auto quick quota
> 263 auto quick quota
>
> N?????r??y????b?X??ǧv?^?){.n?+?????ȧ?\x17??ܨ}???Ơz?&j:+v???\a????zZ+??+zf???h???~????i???z?\x1e?w?????????&?)ߢ^[f
Ummm, what? That looks like some kind of corruption occurred in
transit. There's no mailing list footer, and it's not at my end as
it's in the archive copies, too....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2016-09-20 23:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 22:14 [PATCH 0/3] move xfs non-project quota tests to generic Eric Sandeen
2016-09-20 22:15 ` [PATCH 1/3] xfs/260: fix output to match actions Eric Sandeen
2016-09-22 14:07 ` Bill O'Donnell
2016-09-20 22:21 ` [PATCH 2/3] modify xfs/ quota tests to work on generic filesystems Eric Sandeen
2016-09-21 9:37 ` Eryu Guan
2016-09-21 13:02 ` Eric Sandeen
2016-09-21 14:30 ` Eryu Guan
2016-09-21 14:52 ` Eric Sandeen
2016-09-22 14:09 ` Bill O'Donnell
2016-09-22 18:54 ` [PATCH 2/3 V2] " Eric Sandeen
2016-09-22 18:57 ` Bill O'Donnell
2016-09-20 22:24 ` [PATCH 3/3] move now-generic quota tests to generic Eric Sandeen
2016-09-20 23:40 ` Dave Chinner [this message]
2016-09-21 1:41 ` Eric Sandeen
2016-09-21 6:44 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920234048.GB10454@dastard \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox