From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] fstests: require scratch dev in tests using dm targets
Date: Fri, 23 Sep 2016 08:29:23 +1000 [thread overview]
Message-ID: <20160922222923.GF10454@dastard> (raw)
In-Reply-To: <1474535153-15183-1-git-send-email-eguan@redhat.com>
On Thu, Sep 22, 2016 at 05:05:53PM +0800, Eryu Guan wrote:
> We build dm device on top of scratch dev so we require $SCRATCH_DEV
> to be a valid block device in _require_dm_target(). And we need to
> _require_scratch before _require_dm_target, otherwise test fails if
> there's no SCRATCH_DEV defined, where it should _notrun.
>
> +Usage: _require_block_device <dev>
>
> So add _require_scratch_nocheck to generic/347 (we do the fs check
> on thinp device), move _require_scratch before _require_dm_target in
> xfs/006 and xfs/264.
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2016-09-22 22:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 9:05 [PATCH] fstests: require scratch dev in tests using dm targets Eryu Guan
2016-09-22 22:29 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160922222923.GF10454@dastard \
--to=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox