Re: [PATCH v3] tests/generic: test xfs log recovery metadata LSN ordering

Dave Chinner
2016-09-27T23:44:21Z

On Tue, Sep 27, 2016 at 09:37:30PM +0800, Eryu Guan wrote:
> On Tue, Sep 27, 2016 at 09:12:49AM -0400, Brian Foster wrote:
> > On Mon, Aug 15, 2016 at 08:56:26AM -0400, Brian Foster wrote:
> > > XFS had a bug that lead to a possible out-of-order log recovery
> > > situation (e.g., replay a stale modification from the log over more
> > > recent metadata in destination buffer). This resulted in false
> > > corruption reports during log recovery and thus mount failure.
> > >
> > > This condition is caused by system crash or filesystem shutdown shortly
> > > after a successful log recovery. Add a test to run a combined workload,
> > > fs shutdown and log recovery loop known to reproduce the problem on
> > > affected kernels.
> > >
> > > Signed-off-by: Brian Foster <bfoster@redhat.com>
> > > ---
> > >
> >
> > ping
>
> It's pending in my stage tree, because it crashes current upstream
> kernel, and Dave wants the fixes go upstream first, so the test won't
> crash the test machine and interrupt the test.
>
> I noticed the fixes are in xfs tree for-next branch, I think we're ready
> to include this test in next fstests update.

Yup, it's good to go.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com