From: Dave Chinner <david@fromorbit.com>
To: Zorro Lang <zlang@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] xfs/032: avoid making a 512b block size V5 xfs
Date: Wed, 28 Sep 2016 09:55:03 +1000 [thread overview]
Message-ID: <20160927235503.GC9806@dastard> (raw)
In-Reply-To: <1474989815-8202-1-git-send-email-zlang@redhat.com>
On Tue, Sep 27, 2016 at 11:23:35PM +0800, Zorro Lang wrote:
> If test on a 512b sector size device, xfs/032 will try to do:
>
> mkfs.xfs -s size=512 -b size=512 ...
>
> The 512b block size is not acceptable for V5 XFS. So I change the
> minimum block size to 1024 if (crc = 1 && sector size < 1024).
Why so complex?
The output of the test is empty, so if mkfs.xfs fails with the given
configuration then just skip the loop iteration and run the next
size.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2016-09-27 23:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 15:23 [PATCH] xfs/032: avoid making a 512b block size V5 xfs Zorro Lang
2016-09-27 23:55 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927235503.GC9806@dastard \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox