From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 1/2] generic/052: use _check_scratch_fs not _xfs_check
Date: Thu, 29 Sep 2016 16:28:19 +1000 [thread overview]
Message-ID: <20160929062819.GN9806@dastard> (raw)
In-Reply-To: <1475034250-6909-1-git-send-email-eguan@redhat.com>
On Wed, Sep 28, 2016 at 11:44:09AM +0800, Eryu Guan wrote:
> generic/052 was made generic from an xfs test, and generic functions
> should be used not the xfs-specific ones.
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
> ---
> tests/generic/052 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/generic/052 b/tests/generic/052
> index a81885b..74cf5b6 100755
> --- a/tests/generic/052
> +++ b/tests/generic/052
> @@ -72,7 +72,7 @@ _print_logstate
>
> # curious if FS consistent at start
> if false; then
> - if _xfs_check $SCRATCH_DEV; then
> + if _check_scratch_fs; then
> echo "*** checked ok ***"
> fi
> fi
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2016-09-29 6:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 3:44 [PATCH 1/2] generic/052: use _check_scratch_fs not _xfs_check Eryu Guan
2016-09-28 3:44 ` [PATCH 2/2] xfs/287: fix wrong seq number in test Eryu Guan
2016-09-29 6:29 ` Dave Chinner
2016-09-29 6:28 ` Dave Chinner [this message]
2016-09-29 8:01 ` [PATCH 1/2] generic/052: use _check_scratch_fs not _xfs_check Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160929062819.GN9806@dastard \
--to=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox