Re: [PATCH] generic/349,350,351: remove from quick group

[Eryu Guan <eguan@redhat.com>]

On Thu, Sep 29, 2016 at 03:52:40PM +0800, Zorro Lang wrote:
> On Mon, Sep 26, 2016 at 08:46:32PM +0800, Eryu Guan wrote:
> > These tests are meant to test block devices, so they're not in auto
> > group. And quick group is a subset of auto group, so remove quick as
> > well.
> > 
> > Signed-off-by: Eryu Guan <eguan@redhat.com>
> > ---
> >  tests/generic/group | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/tests/generic/group b/tests/generic/group
> > index 879b1ef..dc8e70d 100644
> > --- a/tests/generic/group
> > +++ b/tests/generic/group
> > @@ -352,9 +352,9 @@
> >  346 auto quick rw
> >  347 auto quick rw thin
> >  348 auto quick metadata
> > -349 blockdev quick rw zero
> > -350 blockdev quick rw punch
> > -351 blockdev quick rw punch collapse insert zero
> > +349 blockdev rw zero
> > +350 blockdev rw punch
> > +351 blockdev rw punch collapse insert zero
> 
> Can we use some methods to check if fallocate supports the features
> for block devices at first? Then decide to keep running or _notrun() these
> cases?
> 
> Because these cases are really 'quick', if they can be run automatically,
> maybe we can add them into auto group?

We didn't add them to 'auto' group on purpose.

http://oss.sgi.com/archives/xfs/2016-03/msg00288.html

I think removing 'quick' group is sufficient at this stage.

Thanks,
Eryu