From: Dave Chinner <david@fromorbit.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] common: add support for the "local" file system type
Date: Fri, 30 Sep 2016 08:49:13 +1000 [thread overview]
Message-ID: <20160929224913.GP9806@dastard> (raw)
In-Reply-To: <20160929130501.k7hz2qcp6tgiyji6@thunk.org>
On Thu, Sep 29, 2016 at 09:05:01AM -0400, Theodore Ts'o wrote:
> On Thu, Sep 29, 2016 at 03:37:52PM +1000, Dave Chinner wrote:
> > Nobody outside the google echo chamber can say, Ted, because you
> > haven't told anyone what it is you want this for. binary emulation
> > layers (your example, not mine) don't implement persistent
> > filesystems - they translate syscalls.
>
> Is your only objection that you don't get to can't see what it's going
> to test?
No, it isn't. But it's the most important one on my list right now
because it affects fundamental architecture assumptions the test
harness is based upon. I haven't looked at the implementation,
because if we can't validate the basic architecture there's no point
even looking at the code.
As it is, Eryu and Eric have already outlined a number of serious
issues with the implementation (and your testing process). They've
highlighted a number of magic snowflake conditions we'd have to
sprinkle throughout random tests and maintain forever more. What's
missing from your patch request is the information that allows us to
determine if the benefits of this patchset outweigh the obvious,
significant, ongoing cost of having to maintain these snowflakes.
Ted, as a kernel subsystem maintainer, you should know that
understanding the full picture is a neccessary aspect of reviewing
new proposals. Do you really merge code into ext4 that you think is
going to be a significant future burden on the maintainer without
knowing why it is needed, how it will be used, or even how you'll
maintain it in a working condition over the long term?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2016-09-29 22:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 20:05 [PATCH] common: add support for the "local" file system type Theodore Ts'o
2016-09-26 13:25 ` Eryu Guan
2016-09-26 15:14 ` Theodore Ts'o
2016-09-27 9:55 ` Eryu Guan
2016-09-29 0:01 ` Theodore Ts'o
2016-09-26 22:18 ` Dave Chinner
2016-09-28 23:57 ` Theodore Ts'o
2016-09-29 2:16 ` Dave Chinner
2016-09-29 3:56 ` Theodore Ts'o
2016-09-29 5:37 ` Dave Chinner
2016-09-29 13:05 ` Theodore Ts'o
2016-09-29 22:49 ` Dave Chinner [this message]
2016-09-30 3:43 ` Theodore Ts'o
2016-09-29 13:37 ` Eric Sandeen
2016-09-29 13:57 ` Eric Sandeen
-- strict thread matches above, loose matches on Subject: below --
2018-05-03 3:43 Theodore Y. Ts'o
2018-05-03 9:22 ` Amir Goldstein
2018-05-03 18:35 ` Theodore Y. Ts'o
2018-05-03 19:24 ` Amir Goldstein
2018-05-06 3:54 ` Eryu Guan
2018-05-12 8:42 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160929224913.GP9806@dastard \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox