From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from aserp1040.oracle.com ([141.146.126.69]:36743 "EHLO
        aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751093AbcJSGE3 (ORCPT
        <rfc822;fstests@vger.kernel.org>); Wed, 19 Oct 2016 02:04:29 -0400
Date: Tue, 18 Oct 2016 23:04:18 -0700
From: "Darrick J. Wong" <darrick.wong@oracle.com>
Subject: Re: [PATCH v2] xfs: remove the device parameter from
 __populate_check_xfs_dir
Message-ID: <20161019060418.GH26485@birch.djwong.org>
References: <20161019044241.GJ14023@dastard>
 <1476855187-7122-1-git-send-email-yangx.jy@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1476855187-7122-1-git-send-email-yangx.jy@cn.fujitsu.com>
Sender: fstests-owner@vger.kernel.org
To: Xiao Yang <yangx.jy@cn.fujitsu.com>
Cc: david@fromorbit.com, fstests@vger.kernel.org
List-ID: <fstests@vger.kernel.org>

On Wed, Oct 19, 2016 at 01:33:07PM +0800, Xiao Yang wrote:
> In commit c08ebd092("xfs: fix $XFS_DB_PROG usage"), the need for callers
> to pass the device to populate into __populate_check_xfs_dir() was removed.
> So we can now clean up all the callers by removing the device parameter.
> 
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

> ---
>  tests/xfs/099 | 2 +-
>  tests/xfs/100 | 2 +-
>  tests/xfs/101 | 2 +-
>  tests/xfs/102 | 2 +-
>  tests/xfs/105 | 2 +-
>  tests/xfs/112 | 2 +-
>  tests/xfs/113 | 2 +-
>  7 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/xfs/099 b/tests/xfs/099
> index ebc02dd..85193ab 100755
> --- a/tests/xfs/099
> +++ b/tests/xfs/099
> @@ -75,7 +75,7 @@ echo "+ check fs"
>  _scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
>  
>  echo "+ check dir"
> -__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" block
> +__populate_check_xfs_dir "${inode}" block
>  
>  echo "+ corrupt dir"
>  _scratch_xfs_db -x -c "inode ${inode}" -c 'dblock 0' -c "stack" -c "blocktrash -x 32 -y $((blksz * 8)) -z ${FUZZ_ARGS}" >> $seqres.full
> diff --git a/tests/xfs/100 b/tests/xfs/100
> index 2412c81..3bfafce 100755
> --- a/tests/xfs/100
> +++ b/tests/xfs/100
> @@ -75,7 +75,7 @@ echo "+ check fs"
>  _scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
>  
>  echo "+ check dir"
> -__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" leaf
> +__populate_check_xfs_dir "${inode}" leaf
>  
>  echo "+ corrupt dir"
>  loff=0
> diff --git a/tests/xfs/101 b/tests/xfs/101
> index 679940f..d3abd19 100755
> --- a/tests/xfs/101
> +++ b/tests/xfs/101
> @@ -75,7 +75,7 @@ echo "+ check fs"
>  _scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
>  
>  echo "+ check dir"
> -__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" leaf
> +__populate_check_xfs_dir "${inode}" leaf
>  
>  echo "+ corrupt dir"
>  _scratch_xfs_db -x -c "inode ${inode}" -c "dblock ${leaf_lblk}" -c "stack" -c "blocktrash -x 32 -y $((blksz * 8)) -z ${FUZZ_ARGS}" >> $seqres.full
> diff --git a/tests/xfs/102 b/tests/xfs/102
> index 8018a9e..cf0d7a6 100755
> --- a/tests/xfs/102
> +++ b/tests/xfs/102
> @@ -75,7 +75,7 @@ echo "+ check fs"
>  _scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
>  
>  echo "+ check dir"
> -__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" node
> +__populate_check_xfs_dir "${inode}" node
>  
>  echo "+ corrupt dir"
>  loff=0
> diff --git a/tests/xfs/105 b/tests/xfs/105
> index 27ee4b3..07ccf00 100755
> --- a/tests/xfs/105
> +++ b/tests/xfs/105
> @@ -75,7 +75,7 @@ echo "+ check fs"
>  _scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
>  
>  echo "+ check dir"
> -__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" node
> +__populate_check_xfs_dir "${inode}" node
>  
>  echo "+ corrupt dir"
>  loff="${leaf_lblk}"
> diff --git a/tests/xfs/112 b/tests/xfs/112
> index c237f03..84f1f1d 100755
> --- a/tests/xfs/112
> +++ b/tests/xfs/112
> @@ -75,7 +75,7 @@ echo "+ check fs"
>  _scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
>  
>  echo "+ check dir"
> -__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" node
> +__populate_check_xfs_dir "${inode}" node
>  
>  echo "+ corrupt dir"
>  loff="${node_lblk}"
> diff --git a/tests/xfs/113 b/tests/xfs/113
> index 6d6e6fd..ec328bc 100755
> --- a/tests/xfs/113
> +++ b/tests/xfs/113
> @@ -75,7 +75,7 @@ echo "+ check fs"
>  _scratch_xfs_repair -n >> $seqres.full 2>&1 || _fail "xfs_repair should not fail"
>  
>  echo "+ check dir"
> -__populate_check_xfs_dir "${SCRATCH_DEV}" "${inode}" btree
> +__populate_check_xfs_dir "${inode}" btree
>  
>  echo "+ corrupt dir"
>  loff=0
> -- 
> 1.8.3.1
> 
> 
>