From: Eryu Guan <eguan@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@lst.de>,
fstests@vger.kernel.org
Subject: Re: [PATCH v3 2/3] fstests: strip quotes from "$XFS_IO_PROG" call sites
Date: Thu, 20 Oct 2016 22:35:59 +0800 [thread overview]
Message-ID: <20161020143559.GK27776@eguan.usersys.redhat.com> (raw)
In-Reply-To: <1476689014-384-2-git-send-email-amir73il@gmail.com>
On Mon, Oct 17, 2016 at 10:23:33AM +0300, Amir Goldstein wrote:
> The value of "$XFS_IO_PROG" may contain extra flags after the
> binary path (e.g. -F), so it is wrong to use the variable inside
> quotes in xfs_io execution call sites.
>
> This bug surfaced while testing the new xfs_io -M flag.
^^^ should be -i now? :)
I can fix it at commit time.
Thanks,
Eryu
next prev parent reply other threads:[~2016-10-20 14:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 7:23 [PATCH v3 1/3] fstests: fix call sites that used xfs_io directly Amir Goldstein
2016-10-17 7:23 ` [PATCH v3 2/3] fstests: strip quotes from "$XFS_IO_PROG" call sites Amir Goldstein
2016-10-20 14:35 ` Eryu Guan [this message]
2016-10-20 17:36 ` Amir Goldstein
2016-10-17 7:23 ` [PATCH v3 3/3] fstests: run xfs_io with -i option is supported Amir Goldstein
2016-10-17 7:31 ` [PATCH v3 3/3] fstests: run xfs_io with -i option if supported Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161020143559.GK27776@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=amir73il@gmail.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox