xfstests mount options?

[Eric Biggers <ebiggers@google.com>]

Hi,

When starting xfstests without $TEST_DEV mounted, it mounts it using this
command in _test_mount, called from init_rc:

    _mount -t $FSTYP $TEST_OPTIONS $TEST_FS_MOUNT_OPTS $SELINUX_MOUNT_OPTIONS $* $TEST_DEV $TEST_DIR

This is also used by _test_cycle_mount, which some tests use.

This is inconsistent with the later code in _check_generic_filesystem, called
after each test, which remounts $TEST_DEV:

    _mount_or_remount_rw "$MOUNT_OPTIONS" $device $mountpoint

It is possible to have mount options in $MOUNT_OPTIONS which then are *not*
included in the options that _test_mount uses.

$TEST_FS_MOUNT_OPTS is also very strange in that it only appears to ever be set
when testing CIFS.

Which version of the test device mount options is correct?  Is it documented
anywhere what is the correct way to configure the mount options used by
xfstests?

Thanks,

Eric