Re: [PATCH] xfs/054: only filter ROOT_INO at the beginning

Dave Chinner
2016-10-25T05:50:20Z

On Sat, Oct 22, 2016 at 01:39:56PM +0800, Eryu Guan wrote:
> In the test ROOT_INO is filtered out or replaced, but if ROOT_INO is
> also 32, more "32"s are filtered or replaced than expected. This
> happens to me when testing 512B block size XFS and 1k block size CRC
> enabled XFS.
>
> Also the ROOT_INO should be the inode number of TEST_DIR not
> SCRATCH_MNT.
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
> ---
> tests/xfs/054 | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/tests/xfs/054 b/tests/xfs/054
> index 7d08f8a..578b752 100755
> --- a/tests/xfs/054
> +++ b/tests/xfs/054
> @@ -52,13 +52,13 @@ _require_test
> _require_xfs_io_command "inode"
>
> # We know the root inode is there
> -ROOT_INO=`ls -id $SCRATCH_MNT | awk '{print $1}'`
> +ROOT_INO=`ls -id $TEST_DIR | awk '{print $1}'`
>
> touch $TEST_DIR/file
>
> $XFS_IO_PROG -c "inode" $TEST_DIR/file
> $XFS_IO_PROG -c "inode -v" $TEST_DIR/file | \
> - grep -vw $ROOT_INO | sed -e s/.*:/LAST:/g
> + grep -vw "^$ROOT_INO" | sed -e s/.*:/LAST:/g

So all of these sed expressions have the modifier "/g" on
them, which means "replace every matching occurrence on the line".
If all we want to do is replace the first match, then we should be
dropping the "g" modifier from the sed expressions...

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com