Re: [PATCH] filter: xfs_io output has dropped "64" from error messages

[Dave Chinner <david@fromorbit.com>]

On Wed, Nov 02, 2016 at 03:23:56PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> Upstream xfs_io has been converted to always use LFS compliant
> (i.e. 64 bit) pwrite() rather than pwrite64(). Similar changes have
> been made for multiple syscalls that have "*64" variants. hence the
> error output of all these commands has changed, such as "pwrite64:
> ..." to "pwrite: ....".
> 
> Make a filter to catch the *64 variants and strip it, and
> convert all the golden output to use the non-*64 variant. This will
> make all golden output matching work correctly regardless of what
> version of xfs_io is in use.
> 
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

....

Actually, overnight testing found a bug in this patch:

> --- a/tests/f2fs/001
> +++ b/tests/f2fs/001
> @@ -69,10 +69,8 @@ $XFS_IO_PROG -t -f -c "falloc 0 5g" $dummyfile | _filter_xfs_io
>  
>  # -ENOSPC should be triggered without any panic
>  echo "==== change i_size & write data ===="
> -$XFS_IO_PROG							\
> -	-c "truncate 96"					\
> -	-c "pwrite -S 0x58 8192 4096"				\
> -$testfile | _filter_xfs_io
> +$XFS_IO_PROG -c "truncate 96" -c "pwrite -S 0x58 8192 4096" $testfile \
> +	| _filter_xfs_io_error

This is missing a 2>&1 redirection, so the filter won't work. I'll
post and updated patch in a minute.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com