Re: [PATCH] fstests: fix error redirection in generic/256

Christoph Hellwig
2017-01-09T13:40:09Z

On Sun, Nov 13, 2016 at 02:39:43AM +0800, Eryu Guan wrote:
> On Sat, Nov 12, 2016 at 08:47:20AM -0800, Christoph Hellwig wrote:
> > Not sure if my shell is the problem here, but I need this explicit
> > redirection to ignore the error output from mkdir and xfs_io, otherwise
> > the test fails due to the error messages from these commands.
>
> That's weird, from bash manpage, "&>" should be equivalent to "> ... 2>&1"
>
> There're many other tests use "&>" as well, do you see such failures
> from other tests, such as generic/347?

No. But 256 keeps on failing for me without this. Given that it's
just a slightly more verbose syntax is there any reason not to just
apply this patch for now?