Re: [f2fs-dev] [PATCH v5] generic/391: check inode metadata on f{data}sync after power-cut

Jaegeuk Kim
2016-11-21T20:02:54Z

This patch adds tests/generic/391 to test fsync and fdatasync with power-cuts.

The rule to check is:
1) fsync should guarantee all the inode metadata after power-cut,
2) fdatasync should guarantee i_size and i_blocks at least after power-cut.

Note that, in XFS, it allocates more blocks when doing writes, so it should
close the file before fsync in order to get actual i_blocks after power-cut.
Or, it needs to do truncate the file with a specific size to turn it off
at the beginning.

Suggested-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
tests/generic/391 | 136 ++++++++++++++++++++++++++++++++++++++++++++++++++
tests/generic/391.out | 11 ++++
tests/generic/group | 1 +
3 files changed, 148 insertions(+)
create mode 100755 tests/generic/391
create mode 100644 tests/generic/391.out

diff --git a/tests/generic/391 b/tests/generic/391
new file mode 100755
index 0000000..fd44a34
--- /dev/null
+++ b/tests/generic/391
@@ -0,0 +1,136 @@
+#! /bin/bash
+# FS QA Test 391
+#
+# Test inode's metadata after fsync or fdatasync calls.
+# In the case of fsync, filesystem should recover all the inode metadata, while
+# recovering i_blocks and i_size at least for fdatasync.
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2016 Jaegeuk Kim. All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+#-----------------------------------------------------------------------
+#
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=0 # failure will be detected in runtime!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+ cd /
+ rm -f $tmp.*
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+. ./common/punch
+
+# real QA test starts here
+_supported_fs generic
+_supported_os Linux
+
+rm -f $seqres.full
+_require_scratch
+_require_scratch_shutdown
+_require_xfs_io_command "fpunch"
+
+_scratch_mkfs >/dev/null 2>&1
+_scratch_mount
+
+testfile=$SCRATCH_MNT/testfile
+
+# check inode metadata after shutdown
+check_inode_metadata()
+{
+ sync_mode=$1
+
+ # fsync or fdatasync
+ if [ $sync_mode = "fsync" ]; then
+ stat_opt='-c "b: %b s: %s a: %x m: %y c: %z"'
+ else
+ stat_opt='-c "b: %b s: %s"'
+ fi
+
+ before=`stat "$stat_opt" $testfile`
+
+ $XFS_IO_PROG -c "$sync_mode" $testfile | _filter_xfs_io
+ src/godown $SCRATCH_MNT | tee -a $seqres.full
+ _scratch_cycle_mount
+
+ after=`stat "$stat_opt" $testfile`
+
+ if [ "$before" != "$after" ]; then
+ echo "Before: $before"
+ echo "After : $after"
+ status=1; # this is a failure!
+ fi
+ echo "Before: $before" >> $seqres.full
+ echo "After : $after" >> $seqres.full
+ rm $testfile
+}
+
+# append XX KB with f{data}sync, followed by power-cut
+test_i_size()
+{
+ echo "==== i_size $2 test with $1 ====" | tee -a $seqres.full
+ $XFS_IO_PROG -f -c "truncate 4M" \
+ -c "pwrite 0 4M" \
+ -c "fsync" \
+ -c "pwrite 4M $2" \
+ $testfile >/dev/null
+ check_inode_metadata $1
+}
+
+# update times with f{data}sync, followed by power-cut
+test_i_time()
+{
+ echo "==== i_time test with $1 ====" | tee -a $seqres.full
+ $XFS_IO_PROG -f -c "truncate 4M" \
+ -c "pwrite 0 4M" \
+ -c "fsync" \
+ $testfile >/dev/null
+ sleep 1
+ touch $testfile
+ check_inode_metadata $1
+}
+
+# punch XX KB with f{data}sync, followed by power-cut
+test_punch()
+{
+ echo "==== fpunch $2 test with $1 ====" | tee -a $seqres.full
+ $XFS_IO_PROG -f -c "truncate 4202496" \
+ -c "pwrite 0 4202496" \
+ -c "fsync" \
+ -c "fpunch 4194304 $2"\
+ $testfile >/dev/null
+ check_inode_metadata $1
+}
+
+for i in fsync fdatasync
+do
+ test_i_size $i 1024
+ test_i_size $i 4096
+ test_i_time $i
+ test_punch $i 1024
+ test_punch $i 4096
+done
+
+exit
diff --git a/tests/generic/391.out b/tests/generic/391.out
new file mode 100644
index 0000000..7c66776
--- /dev/null
+++ b/tests/generic/391.out
@@ -0,0 +1,11 @@
+QA output created by 391
+==== i_size 1024 test with fsync ====
+==== i_size 4096 test with fsync ====
+==== i_time test with fsync ====
+==== fpunch 1024 test with fsync ====
+==== fpunch 4096 test with fsync ====
+==== i_size 1024 test with fdatasync ====
+==== i_size 4096 test with fdatasync ====
+==== i_time test with fdatasync ====
+==== fpunch 1024 test with fdatasync ====
+==== fpunch 4096 test with fdatasync ====
diff --git a/tests/generic/group b/tests/generic/group
index 08007d7..9de3415 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -392,3 +392,4 @@
387 auto clone
388 auto log metadata
389 auto quick acl
+391 auto quick metadata
--
2.8.3