From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mx1.redhat.com ([209.132.183.28]:39972 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754190AbcK3KKb (ORCPT <rfc822;fstests@vger.kernel.org>);
        Wed, 30 Nov 2016 05:10:31 -0500
Date: Wed, 30 Nov 2016 18:10:28 +0800
From: Eryu Guan <eguan@redhat.com>
Subject: Re: [PATCH 0/2] common: make common/rc easier to manage
Message-ID: <20161130101028.GS22989@eguan.usersys.redhat.com>
References: <20161129213233.8462-1-david@fromorbit.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161129213233.8462-1-david@fromorbit.com>
Sender: fstests-owner@vger.kernel.org
To: Dave Chinner <david@fromorbit.com>
Cc: fstests@vger.kernel.org
List-ID: <fstests@vger.kernel.org>

On Wed, Nov 30, 2016 at 08:32:31AM +1100, Dave Chinner wrote:
> Hi folks,
> 
> common/rc has grown huge with lots of library functions, and it's
> becoming hard to manage. The following two patches split the XFS and
> btrfs specific functionality in common/rc into separate files which
> are sourced directly from common/rc based on $FSTYP.

Thanks, Dave!

> 
> This moves a large chunk of code spread throughout common/rc into
> smaller, more contained files where it is easier to see how the
> filesystem specific pieces are put together. I'd like to see this
> happen for other filesytems, and quite possibly other groups of
> functionality that make sense to manage separately.
> 
> Thoughts and comments welcome!

They look good to me, and I'm testing them now. Two things I noticed:
- Can we take this opportunity to fix some code style issues, along with
  the movement? e.g. tab indention, if-then-else-fi format and while-do
  format and whitespace issues.
- Should _require_scratch_richacl_xfs() be moved to common/xfs too?

Thanks,
Eryu