Re: [PATCH 0/2] common: make common/rc easier to manage

[Eryu Guan <eguan@redhat.com>]

On Thu, Dec 01, 2016 at 08:11:04AM +1100, Dave Chinner wrote:
> On Wed, Nov 30, 2016 at 06:10:28PM +0800, Eryu Guan wrote:
> > On Wed, Nov 30, 2016 at 08:32:31AM +1100, Dave Chinner wrote:
> > > Hi folks,
> > > 
> > > common/rc has grown huge with lots of library functions, and it's
> > > becoming hard to manage. The following two patches split the XFS and
> > > btrfs specific functionality in common/rc into separate files which
> > > are sourced directly from common/rc based on $FSTYP.
> > 
> > Thanks, Dave!
> > 
> > > 
> > > This moves a large chunk of code spread throughout common/rc into
> > > smaller, more contained files where it is easier to see how the
> > > filesystem specific pieces are put together. I'd like to see this
> > > happen for other filesytems, and quite possibly other groups of
> > > functionality that make sense to manage separately.
> > > 
> > > Thoughts and comments welcome!
> > 
> > They look good to me, and I'm testing them now. Two things I noticed:
> > - Can we take this opportunity to fix some code style issues, along with
> >   the movement? e.g. tab indention, if-then-else-fi format and while-do
> >   format and whitespace issues.
> 
> In the patch that moves the code, no. In follow-on cleanup patches,
> yes.

I'll post a cleanup patch soon.

> 
> > - Should _require_scratch_richacl_xfs() be moved to common/xfs too?
> 
> I ignored that for the moment because XFS doesn't actually have any
> richacl support and I didn't want to think about how the richacl
> checks might be best separated.

OK, let's keep it in common/rc for now.

Thanks,
Eryu