From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ipmail06.adl2.internode.on.net ([150.101.137.129]:10509 "EHLO ipmail06.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754576AbcLBGws (ORCPT ); Fri, 2 Dec 2016 01:52:48 -0500 Date: Fri, 2 Dec 2016 17:51:28 +1100 From: Dave Chinner Subject: Re: [PATCH] common: cleanups after common/rc split Message-ID: <20161202065128.GJ11750@dastard> References: <20161201042213.16859-1-eguan@redhat.com> <20161202032935.GH11750@dastard> <20161202033504.GF29149@eguan.usersys.redhat.com> <20161202062533.GJ29149@eguan.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161202062533.GJ29149@eguan.usersys.redhat.com> Sender: fstests-owner@vger.kernel.org To: Eryu Guan Cc: fstests@vger.kernel.org List-ID: On Fri, Dec 02, 2016 at 02:25:33PM +0800, Eryu Guan wrote: > On Fri, Dec 02, 2016 at 11:35:04AM +0800, Eryu Guan wrote: > ... > > > > + if [ $ok -eq 0 ]; then > > > > + echo "*** mount output ***" >>$seqres.full > > > > + _mount >>$seqres.full > > > > + echo "*** end mount output" >>$seqres.full > > > > + elif [ "$type" = "xfs" ]; then > > > > + _mount_or_remount_rw "$extra_mount_options" $device $mountpoint > > I looked at this more and I think that a "ok=$?" is missed here > (_mount_or_remount_rw return 1 as success), both > _check_generic_filesystem and _check_btrfs_filesystem do this. So if it > passes the first $ok check then does this rw mount and sets $ok based on > the mount result. I'll just add a "ok=$?" here. Sounds good. :P Cheers, Dave. -- Dave Chinner david@fromorbit.com