Re: [PATCH v2] xfs_io: support -c "open foo" command

[Dave Chinner <david@fromorbit.com>]

On Tue, Dec 06, 2016 at 07:24:12AM +0200, Amir Goldstein wrote:
> On Tue, Dec 6, 2016 at 12:15 AM, Dave Chinner <david@fromorbit.com> wrote:
> > It's the command loop iteration problem we need to fix, not neuter
> > the multiple file capability of xfs_io.
> >
> 
> OK, v4 it is.
> For some reason you fail to spell out your idea of "fixing",
> so I keep having to guess what you mean.

I outlined the probable fix last week:

https://www.spinics.net/lists/fstests/msg04544.html

i.e. fix the one-shot commands with CMD_FLAG_GLOBAL, but indicated
we'd need to look at the git history to be sure of what is
necessary.

> This time I am guessing that you mean:
> - open all the files in args list (all using the same -r/-f flags)
> - iterate all commands exactly once without implicitly changing "file"

Nope. I meant "go look at the git history and determine what the
historical behaviour was and determine how we ended up with this
mess. Then from that analysis, decide what to do."

Unfortunately, you haven't shown any indication that you've looked
at the git history, nor that you actually listened to me about the
CMD_FLAG_GLOBAL. I've now done that code archeology and it indicates
that my suggestion was correct.

If you didn't understand what I suggested, then say so clearly and
unambiguously so I know I need to explain it more clearly.  The
/worst/ thing you can do is keep sending new patches that take the
same path to one I've already NACKed without having looked at the
solution I proposed or done the historical analysis I suggested was
necessary.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com