From: Eric Biggers <ebiggers3@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] kvm-xfstests, gce-xfstests: correct file permissions with --update-files
Date: Fri, 9 Dec 2016 13:21:03 -0800 [thread overview]
Message-ID: <20161209212103.GA64048@google.com> (raw)
In-Reply-To: <1479260456-6723-1-git-send-email-ebiggers@google.com>
On Tue, Nov 15, 2016 at 05:40:56PM -0800, Eric Biggers wrote:
> The xfstests-bld repository may have been cloned with a umask that
> masked out the other bits. When using --update-files in this situation,
> the VM ended up in a state where non-root users were unable to execute
> anything, which made all tests using the fsgqa user get skipped. Fix
> this by copying the r and x group bits to the other bits when creating
> files.tar.gz. Also set the owner and group to root while we're at it.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Hi Ted, are you planning to apply this patch? I see you applied the patch to
fix --update-xfstests-tar but not this one, to fix --update-files.
Thanks!
Eric
prev parent reply other threads:[~2016-12-09 21:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 1:40 [PATCH] kvm-xfstests, gce-xfstests: correct file permissions with --update-files Eric Biggers
2016-12-09 21:21 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161209212103.GA64048@google.com \
--to=ebiggers3@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox