From: "Theodore Ts'o" <tytso@mit.edu>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: fstests@vger.kernel.org, Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH v2] xfstests-bld: correct file permissions on test appliance files
Date: Thu, 22 Dec 2016 11:55:51 -0500 [thread overview]
Message-ID: <20161222165551.qvccd2sv3ujhkgkk@thunk.org> (raw)
In-Reply-To: <1482343592-135031-1-git-send-email-ebiggers3@gmail.com>
On Wed, Dec 21, 2016 at 10:06:27AM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> The xfstests-bld repository may have been cloned with a umask that
> masked out the other bits. When using --update-files in this situation
> or when creating a GCE image, the VM ended up in a state where non-root
> users were unable to execute anything, which made all tests using the
> fsgqa user get skipped. Fix this by copying the r and x group bits to
> the other bits when creating files.tar.gz. Also set the owner and group
> to root while we're at it.
Wouldn't it be better to use "--mode=go+u-w"? This will solve the
problem for those people who use a umask of 077.
- Ted
next prev parent reply other threads:[~2016-12-22 16:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 18:06 [PATCH v2] xfstests-bld: correct file permissions on test appliance files Eric Biggers
2016-12-22 16:55 ` Theodore Ts'o [this message]
2016-12-28 21:07 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161222165551.qvccd2sv3ujhkgkk@thunk.org \
--to=tytso@mit.edu \
--cc=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox