From: Eric Biggers <ebiggers3@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org, Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH] xfstests-bld: document how to add debian packages to GCE image
Date: Wed, 28 Dec 2016 15:21:32 -0600 [thread overview]
Message-ID: <20161228212132.GB8557@zzz> (raw)
In-Reply-To: <20161222170433.cbyrt2phsapq2tr7@thunk.org>
On Thu, Dec 22, 2016 at 12:04:33PM -0500, Theodore Ts'o wrote:
> On Wed, Dec 21, 2016 at 10:06:28AM -0800, Eric Biggers wrote:
> > +build your own image, you must first build a 64-bit (amd64) xfstests
> > +tarball as described in the [instructions for building
> > +xfstests](building-xfstests.md). Then copy any additional Debian
> > +packages, for the amd64 architecture, you want to include in the GCE
> > +image into the root directory of GS_BUCKET.
>
> This is phrased a bit awkwardly. The official way is to put the
> debian packages in kvm-xfstests/test-appliances/debs. This works for
> both building gce-xfstests and kvm-xfstests images.
>
That works with kvm-xfstests (gen-image), but it didn't work when I tried it
with gce-xfstests (gce-create-image) because nothing was actually copying the
debian packages into the GS bucket for the test appliance to install. How about
we update gce-create-image to copy the debian packages from
test-appliances/debs/ into the GS bucket (maybe gsutil rsync -d to a directory
'debs'), so that it works in the way you're suggesting?
Also, Documentation/building-rootfs.md already describes adding packages for
kvm-xfstests; it's just gce-xfstests that was missing the documentation. So
perhaps the gce-xfstests documentation should refer to the kvm-xfstests
documentation for full details on adding packages, if the procedure is going to
be the same.
Eric
next prev parent reply other threads:[~2016-12-28 21:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 18:06 [PATCH] xfstests-bld: document how to add debian packages to GCE image Eric Biggers
2016-12-22 17:04 ` Theodore Ts'o
2016-12-28 21:21 ` Eric Biggers [this message]
2016-12-31 15:52 ` Theodore Ts'o
2017-01-07 17:00 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161228212132.GB8557@zzz \
--to=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=fstests@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox