public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH] fstests: Fix inconsistent xfs_io error report caused false alert
Date: Wed, 4 Jan 2017 16:55:16 +0800	[thread overview]
Message-ID: <20170104085516.GQ1859@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20170104083708.5268-1-quwenruo@cn.fujitsu.com>

On Wed, Jan 04, 2017 at 04:37:08PM +0800, Qu Wenruo wrote:
> Test case like generic/304 and generic/158 can cause false alert due to
> the error output change of xfs_io.
> 
> For error case, xfs_io mostly reports error like "dedupe: ERROR STRING"
> while under certain case, it reports error like "XFS_IOC_FILE_EXTENT_SAME:
> ERROR STRING".
> 
> Fix it by adding a new filter, _filter_dedupe_ioctl(), to filter out all
> "XFS_IOC_FILE_EXTENT_SAME:" to "dedupe:"
> 
> Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>

Thanks for the patch! I've sent a similiar patch to address this issue :)

http://www.spinics.net/lists/fstests/msg04822.html

And Darrick suggested to do a "reverse" filter today.

http://www.spinics.net/lists/fstests/msg04837.html

Thanks,
Eryu

      reply	other threads:[~2017-01-04  9:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-04  8:37 [PATCH] fstests: Fix inconsistent xfs_io error report caused false alert Qu Wenruo
2017-01-04  8:55 ` Eryu Guan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170104085516.GQ1859@eguan.usersys.redhat.com \
    --to=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox