From: "Theodore Ts'o" <tytso@mit.edu>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: fstests@vger.kernel.org, Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH v4] xfstests-bld: correct file permissions on test appliance files
Date: Sat, 7 Jan 2017 11:43:07 -0500 [thread overview]
Message-ID: <20170107164307.5w7ordjrg3sjpkns@thunk.org> (raw)
In-Reply-To: <20170105003137.112962-1-ebiggers3@gmail.com>
On Wed, Jan 04, 2017 at 04:31:37PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> The xfstests-bld repository may have been cloned with a umask that
> masked out the group and/or the other bits. When using --update-files
> in this situation or when creating a GCE image, the VM ended up in a
> state where non-root users were unable to execute the binaries in
> /root/xfstests, which made all tests using the fsgqa user get skipped.
> Fix this by copying the r and x user bits to the group and other bits
> when creating files.tar.gz, creating xfstests.tar.gz, or copying files
> directly to the kvm-xfstests appliance. Also consistently set the owner
> and group to root.
>
> Note that git doesn't actually store file owners, groups, or any mode
> bits other than "is the file executable"? So this patch really just
> enforces a consistent, sane default for this "unstored" metadata.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Applied, thanks.
- Ted
prev parent reply other threads:[~2017-01-07 16:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 0:31 [PATCH v4] xfstests-bld: correct file permissions on test appliance files Eric Biggers
2017-01-07 16:43 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170107164307.5w7ordjrg3sjpkns@thunk.org \
--to=tytso@mit.edu \
--cc=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox