From: David Disseldorp <ddiss@suse.de>
To: fstests@vger.kernel.org
Cc: David Disseldorp <ddiss@suse.de>
Subject: [PATCH 1/3] xfs/188: add and use _require_xfs_mkfs_ciname
Date: Thu, 12 Jan 2017 18:18:47 +0100 [thread overview]
Message-ID: <20170112171849.10784-1-ddiss@suse.de> (raw)
In-Reply-To: <20170112132656.7caa64dd@suse.de>
Use an explicit mkfs -n version=ci test to check whether the test should
run, instead of checking the xfsprogs version.
Suggested-by: Eryu Guan <eguan@redhat.com>
Signed-off-by: David Disseldorp <ddiss@suse.de>
---
common/xfs | 7 +++++++
tests/xfs/188 | 6 +-----
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/common/xfs b/common/xfs
index fbd139a..767a481 100644
--- a/common/xfs
+++ b/common/xfs
@@ -587,3 +587,10 @@ _require_meta_uuid()
|| _notrun "Kernel doesn't support meta_uuid feature"
_scratch_unmount
}
+
+# this test requires mkfs.xfs have case-insensitive naming support
+_require_xfs_mkfs_ciname()
+{
+ _scratch_mkfs_xfs_supported -n version=ci >/dev/null 2>&1 \
+ || _notrun "need case-insensitive naming support in mkfs.xfs"
+}
diff --git a/tests/xfs/188 b/tests/xfs/188
index 6332085..8798ecf 100755
--- a/tests/xfs/188
+++ b/tests/xfs/188
@@ -52,12 +52,8 @@ _cleanup()
# real QA test starts here
_supported_fs xfs
_supported_os IRIX Linux
-
-if [ $XFSPROGS_VERSION -lt 21000 ]; then
- _notrun "this test requires case-insensitive support"
-fi
-
_require_scratch
+_require_xfs_mkfs_ciname
rm -f $seqres.full
_scratch_mkfs -n version=ci >/dev/null 2>&1
--
2.10.2
next prev parent reply other threads:[~2017-01-12 17:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 10:48 [PATCH] common: use xfs_io to obtain the xfsprogs version David Disseldorp
2017-01-11 13:25 ` Eric Sandeen
2017-01-12 3:51 ` Eryu Guan
2017-01-12 12:26 ` David Disseldorp
2017-01-12 17:18 ` David Disseldorp [this message]
2017-01-12 17:18 ` [PATCH 2/3] common: remove unused XFSPROGS_VERSION check David Disseldorp
2017-01-12 17:18 ` [PATCH 3/3] common: remove tmp.mkfs[err/std] files by name David Disseldorp
2017-01-13 4:24 ` Eryu Guan
2017-01-13 10:11 ` David Disseldorp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112171849.10784-1-ddiss@suse.de \
--to=ddiss@suse.de \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox