From: Eryu Guan <eguan@redhat.com>
To: Xiao Yang <yangx.jy@cn.fujitsu.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH v2] common/rc: Fix _supports_filetype function
Date: Mon, 16 Jan 2017 16:20:47 +0800 [thread overview]
Message-ID: <20170116082047.GF1859@eguan.usersys.redhat.com> (raw)
In-Reply-To: <1484554040-4231-1-git-send-email-yangx.jy@cn.fujitsu.com>
On Mon, Jan 16, 2017 at 04:07:20PM +0800, Xiao Yang wrote:
> generic/401 failed on RHEL6.8GA because "--output=xxx"
> option is not supported by df. So we remove it.
>
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> ---
> common/rc | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/common/rc b/common/rc
> index 892c46e..87ef849 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -268,14 +268,14 @@ _supports_filetype()
> {
> local dir=$1
>
> - local fstyp=$(df --output=fstype $dir | tail -1)
> + local fstyp=`$DF_PROG $dir | tail -1 | $AWK_PROG '{print $2}'`
> case "$fstyp" in
> xfs)
> xfs_info $dir | grep -q "ftype=1"
> ;;
> ext2|ext3|ext4)
> - tune2fs -l $(df --output=source $dir | tail -1) | \
> - grep -q filetype
> + local mntdir=`$DF_PROG $dir | tail -1 | $AWK_PROG '{print $1}'`
^^^^^^ this actually is the underlying device
I'll rename it to "dev" on commit.
Thanks,
Eryu
> + tune2fs -l $mntdir | grep -q filetype
> ;;
> *)
> local testfile=$dir/$$.ftype
> --
> 1.8.3.1
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-01-16 8:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 6:40 [PATCH] common/rc: use $FSTYP and $SCRATCH_DEV in _supports_filetype function Xiao Yang
2017-01-16 7:23 ` Eryu Guan
2017-01-16 8:04 ` Xiao Yang
2017-01-16 8:07 ` [PATCH v2] common/rc: Fix " Xiao Yang
2017-01-16 8:20 ` Eryu Guan [this message]
2017-01-16 8:24 ` Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116082047.GF1859@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=yangx.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox