Re: [PATCH] fstests: cleanup $TEST_DIR/$seq* files

[Eryu Guan <eguan@redhat.com>]

On Fri, Jan 27, 2017 at 12:39:49PM +0200, Amir Goldstein wrote:
> Test generic/007 was failing after running test overlay/007,
> because the latter left behind a directory named 007 in test dir
> and the former failed to mkdir a directory with the same name.
> 
> Greping the tests for the pattern $TEST_DIR/$seq* found some more
> files/dirs of this sort that were not being cleaned up.
> 
> Clean those files/dir on _cleanup trap to fix the 007 tests collision
> and avoid similar collisions in future tests.
> 
> Left the directories $TEST_DIR/$seq.mnt in tact, because they are
> always empty and created with mkdir -p.
> 
> There are more files left behind as can be seen in any aged test dir.

TEST_DIR is supposed to be aged over multiple runs, so leaving test
files in it should be just fine, unless these files are consuming a lot
of free space and would block subsequent tests.

For tests that need an empty dir or a newly created file in TEST_DIR,
they could just remove the dir or file in test setup phase before doing
any actual setups.

So I think adding "-p" to mkdir command in generic/007 looks sufficient.

Thanks,
Eryu