From: Christoph Hellwig <hch@lst.de>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH] generic/407: check that destination timestamps are updated on clone
Date: Fri, 3 Feb 2017 11:34:18 +0100 [thread overview]
Message-ID: <20170203103418.GA29484@lst.de> (raw)
In-Reply-To: <CAOQ4uxh4Wp8YtX283=X0Kp=8BXZCdeoPamBAwimpq2RmZkxkKg@mail.gmail.com>
On Fri, Feb 03, 2017 at 12:32:21PM +0200, Amir Goldstein wrote:
> Yes, I saw that, generic/215 which was copied from generic/080 I guess
> someone should clean up those 2 some time.
>
> And while we are busy saving more angels lives, do 407 and 408 really need
> to be separate tests?
> How about consolidating them into a single test that works with 2 sets of files?
> Sorry again for nit picking on those lost seconds.
We can't do that as there are file systems that support clone but not
dedup (e.g. NFS).
next prev parent reply other threads:[~2017-02-03 10:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 16:27 [PATCH] generic/407: check that destination timestamps are updated on clone Christoph Hellwig
2017-02-02 19:43 ` Amir Goldstein
2017-02-02 19:46 ` Amir Goldstein
2017-02-03 9:56 ` Christoph Hellwig
2017-02-03 10:32 ` Amir Goldstein
2017-02-03 10:34 ` Christoph Hellwig [this message]
2017-02-02 20:17 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170203103418.GA29484@lst.de \
--to=hch@lst.de \
--cc=amir73il@gmail.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox