From: Christoph Hellwig <hch@lst.de>
To: Eryu Guan <eguan@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, fstests@vger.kernel.org
Subject: Re: [PATCH 1/2] generic/407: check that destination timestamps are updated on clone
Date: Sat, 4 Feb 2017 11:02:45 +0100 [thread overview]
Message-ID: <20170204100245.GB18697@lst.de> (raw)
In-Reply-To: <20170204041526.GF1859@eguan.usersys.redhat.com>
On Sat, Feb 04, 2017 at 12:15:26PM +0800, Eryu Guan wrote:
> > +# get standard environment, filters and checks
> > +. ./common/rc
> > +. ./common/filter
> > +. common/reflink
>
> For consistency, ". ./common/reflink" looks better.
Sure, this was fat fingered anyway :)
> > +
> > +# real QA test starts here
> > +_supported_fs generic
> > +_supported_os Linux
> > +
> > +_require_test
> > +_require_test_reflink
> > +_require_cp_reflink
>
> This seems not necessary, cp is not used and xfs_io reflink command is
> checked in _require_test_reflink.
Yeah - the first version used cp, but I changed it later so this an be
safely dropped.
> Otherwise looks good to me. I can fix them at commit time.
Please do, thanks a lot!
next prev parent reply other threads:[~2017-02-04 10:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 9:58 clone/dedup timestamp tests V2 Christoph Hellwig
2017-02-03 9:58 ` [PATCH 1/2] generic/407: check that destination timestamps are updated on clone Christoph Hellwig
2017-02-04 4:15 ` Eryu Guan
2017-02-04 10:02 ` Christoph Hellwig [this message]
2017-02-03 9:58 ` [PATCH 2/2] generic/408: check that destination timestamps are not updated on dedupe Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170204100245.GB18697@lst.de \
--to=hch@lst.de \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox