public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers3@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org, Eric Biggers <ebiggers@google.com>
Subject: [PATCH] xfstests-bld: format filesystem with '-O encrypt' in encrypt config
Date: Mon,  6 Feb 2017 13:42:34 -0800	[thread overview]
Message-ID: <20170206214237.8838-2-ebiggers3@gmail.com> (raw)

From: Eric Biggers <ebiggers@google.com>

We were relying on the kernel setting the 'encrypt' feature flag for us.
We should just do it in userspace when formatting the filesystem.  This
will allow us to eventually remove the kernel-side hack to force-set the
'encrypt' flag in the superblock.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt
index 390e205..320eff0 100644
--- a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt
+++ b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt
@@ -1,5 +1,5 @@
 SIZE=small
-export MKFS_OPTIONS=""
+export MKFS_OPTIONS="-O encrypt"
 export EXT_MOUNT_OPTIONS="test_dummy_encryption"
 REQUIRE_FEATURE=encryption
 TESTNAME="Ext4 encryption"
-- 
2.11.0.483.g087da7b7c-goog


             reply	other threads:[~2017-02-06 21:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-06 21:42 Eric Biggers [this message]
2017-02-07 17:40 ` [PATCH] xfstests-bld: format filesystem with '-O encrypt' in encrypt config Theodore Ts'o
  -- strict thread matches above, loose matches on Subject: below --
2016-12-13  6:59 Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170206214237.8838-2-ebiggers3@gmail.com \
    --to=ebiggers3@gmail.com \
    --cc=ebiggers@google.com \
    --cc=fstests@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox